Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the traceshift undefined variable bug #2428

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix the traceshift undefined variable bug #2428

merged 1 commit into from
Dec 13, 2024

Conversation

segasai
Copy link
Contributor

@segasai segasai commented Dec 13, 2024

Fixes the #2427
Sorry for introducing it.
(can't test it myself, but I think it should do it).

@coveralls
Copy link

Coverage Status

coverage: 39.44% (-0.003%) from 39.443%
when pulling e12795b on fix_traceshift
into 3c6b692 on main.

@julienguy
Copy link
Contributor

I tested the fix in the context of a nightwatch run of an arc exposure (which crashes with main and works with this branch):

nightwatch run -n 20241211 -e 00267785 --cameras b0,r0,z0 -o .

Merging.

@julienguy julienguy merged commit e4e6142 into main Dec 13, 2024
20 of 26 checks passed
@julienguy julienguy deleted the fix_traceshift branch December 13, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants