Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit how individual cameras are co-added in specsim results #32

Open
dkirkby opened this issue Feb 20, 2016 · 2 comments
Open

Revisit how individual cameras are co-added in specsim results #32

dkirkby opened this issue Feb 20, 2016 · 2 comments

Comments

@dkirkby
Copy link
Member

dkirkby commented Feb 20, 2016

Specsim returns per-camera vectors as well as co-added results. We currently only use the per-camera results in quickbrick and quickgen, but for SNR-level studies a co-add is still useful.

The coadd is currently throughput weighted:

obsflux = sum( thru[c] * resolution.dot(srcflux) ) / sum ( thru[c] )

where both sums are over cameras only.

Should we move to ivar weights, or even a full-blown spectro-perfect co-add (a la desi-doc-1056) ?

This is related to #1.

@dkirkby
Copy link
Member Author

dkirkby commented Mar 9, 2016

PR #35 removes the co-added output since it was not being used and needs to be re-thought once we have an actual use for it. I am leaving this open for now but adding the "enhancement" label.

@sbailey
Copy link
Contributor

sbailey commented Mar 9, 2016

Although the specsim coadd isn't currently being used by the simulation pipeline, the heritage of specsim (i.e. quicksim) was originally all about providing a convenient single spectrum representing a reasonably realistic version of what DESI will produce, without having to involve the user in the messiness of individual channels. Similarly for e/BOSS, nearly all users work with the coadds (if they work with the spectra at all). In our drive to add more realism, we should be cautious about dropping that original goal.

i.e. ok to temporarily drop it, but let's not let the idea of perfect coadds get in the way of providing good enough coadds for non-expert users. Let's get coadds back in the next round of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants