Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc UI fixes #64

Open
unc0ded opened this issue Oct 30, 2020 · 6 comments
Open

Misc UI fixes #64

unc0ded opened this issue Oct 30, 2020 · 6 comments

Comments

@unc0ded
Copy link
Contributor

unc0ded commented Oct 30, 2020

Description

  1. Splash screen status bar color does not match the general app status bar color.
  2. White status bar color makes the status bar icons illegible (Red is better, or maybe red with a little less alpha).
  3. Expanded app bar text color in RestaurantDetails is a darker color, white would perhaps be more legible.
  4. 'Clear Filter' chip fontFamily has not been changed.

Screenshot/Recording

1. 2. 3. 4.

@epicadk
Copy link
Contributor

epicadk commented Oct 30, 2020

For the 3rd one it's pretty hard because there might always be clashing colors not matter what color you set. You can actually do it based on the background color of the image however it seems pretty tedious although I saw that composed does make it easier.

@unc0ded
Copy link
Contributor Author

unc0ded commented Oct 30, 2020

For the 3rd one it's pretty hard because there might always be clashing colors not matter what color you set. You can actually do it based on the background color of the image however it seems pretty tedious although I saw that composed does make it easier.

I know, but most images seem to be on the darker side currently, so having text as white should be a temporary fix at least.

@devansh-299
Copy link
Owner

Nice findings @unc0ded !

  • I couldn't reproduce [2] in my device. Probably should have tested it more before making a commit
  • For [3] we can use Palette API to fetch relevant colors
  • I solved [4] in the latest commit.

@unc0ded
Copy link
Contributor Author

unc0ded commented Oct 30, 2020

  • I couldn't reproduce [2] in my device. Probably should have tested it more before making a commit

I tested on two devices at my end, both seemed to have the same 'white on white' issue.

@shreyashcode
Copy link

Is the issue resolved?

@unc0ded
Copy link
Contributor Author

unc0ded commented Nov 11, 2020

Not yet, there's a pending PR fixing some of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants