test: Improve test to use lifecycleHooks

Author: max06

src/test/cli.build.test.ts

@@ -260,11 +260,5 @@ describe('Dev Containers CLI', function () {
 			const details = JSON.parse((await shellExec(`docker inspect test-subfolder-config`)).stdout)[0] as ImageDetails;
 			assert.strictEqual(envListToObj(details.Config.Env).SUBFOLDER_CONFIG_IMAGE_ENV, 'true');
 		});
-
-		it('should build with a local feature', async () => {
-			const res = await shellExec(`${cli} build --workspace-folder ${__dirname}/configs/image-with-local-feature --image-name test-local-feature`)
-			const response = JSON.parse(res.stdout);
-			assert.strictEqual(response.outcome, 'success');
-		});
 	});
 });

src/test/configs/image-with-local-feature/.devcontainer/devcontainer.json renamed to src/test/container-features/configs/image-with-local-feature/.devcontainer/devcontainer.json

@@ -10,5 +10,6 @@
 			"target": "/home/${remoteUser}",
 			"type": "volume"
 		}
-	]
+	],
+	"postCreateCommand": "/usr/bin/whoami && echo ${remoteUser} > /tmp/variable-substitution.testMarker"
 }

src/test/configs/image-with-local-feature/.devcontainer/test-feature/devcontainer-feature.json renamed to src/test/container-features/configs/image-with-local-feature/.devcontainer/test-feature/devcontainer-feature.json

@@ -371,6 +371,38 @@ describe('Feature lifecycle hooks', function () {
 		});
 	});
 
+	describe('lifecycle-hooks-with-variable-substitution', () => {
+		describe('devcontainer up', () => {
+			let containerId: string | null = null;
+			let containerUpStandardError: string;
+			const testFolder = `${__dirname}/configs/image-with-local-feature`;
+
+			before(async () => {
+				await shellExec(`rm -f ${testFolder}/*.testMarker`, undefined, undefined, true);
+				const res = await devContainerUp(cli, testFolder, { 'logLevel': 'trace' });
+				containerId = res.containerId;
+				containerUpStandardError = res.stderr;
+			});
+
+			after(async () => {
+				await devContainerDown({ containerId });
+				await shellExec(`rm -f ${testFolder}/*.testMarker`, undefined, undefined, true);
+			});
+
+			it('executes lifecycle hooks with variable substitution', async () => {
+				const res = await shellExec(`${cli} exec --workspace-folder ${testFolder} cat /tmp/variable-substitution.testMarker`);
+				assert.strictEqual(res.error, null);
+
+				const outputOfExecCommand = res.stdout;
+				console.log(outputOfExecCommand);
+
+				// Executes the command that was installed by the local Feature's 'postCreateCommand'.
+				assert.match(outputOfExecCommand, /vscode/);
+				assert.match(containerUpStandardError, /Running the postCreateCommand from Feature '.\/test-feature/);
+			});
+		});
+	});
+
 	describe('lifecycle-hooks-advanced', () => {
 
 		describe(`devcontainer up`, () => {