Skip to content

Commit f3c3468

Browse files
authored
Merge branch 'devcontainers:main' into main
2 parents 68d738e + da16ca9 commit f3c3468

File tree

6 files changed

+258
-279
lines changed

6 files changed

+258
-279
lines changed

.github/dependabot.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,13 @@ updates:
1818
- "*"
1919
ignore:
2020
- dependency-name: "@stylistic/eslint-plugin"
21-
update-types: ["version-update:semver-major"] # stylistic 4 to avoid esm
21+
update-types: ["version-update:semver-major"] # stylistic 3 to avoid esm
22+
- dependency-name: "@types/chai"
23+
update-types: ["version-update:semver-major"] # chai 4 to avoid esm
2224
- dependency-name: "@types/node"
2325
update-types: ["version-update:semver-major"] # Keep Node 18 compatibility
26+
- dependency-name: "@types/tar"
27+
update-types: ["version-update:semver-major"] # tar 6 for source compatibility
2428
- dependency-name: "chai"
2529
update-types: ["version-update:semver-major"] # chai 4 to avoid esm
2630
- dependency-name: "eslint"

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
Notable changes.
44

5+
## April 2025
6+
7+
### [0.76.0]
8+
- Fix: Add Podman options (https://github.com/microsoft/vscode-remote-release/issues/10798)
9+
- Fix: Restore accidental robustness towards numbers (https://github.com/microsoft/vscode-remote-release/issues/10691)
10+
511
## March 2025
612

713
### [0.75.0]

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@devcontainers/cli",
33
"description": "Dev Containers CLI",
4-
"version": "0.75.0",
4+
"version": "0.76.0",
55
"bin": {
66
"devcontainer": "devcontainer.js"
77
},
@@ -55,7 +55,7 @@
5555
],
5656
"devDependencies": {
5757
"@stylistic/eslint-plugin": "^3.0.1",
58-
"@types/chai": "^5.2.0",
58+
"@types/chai": "^4.3.20",
5959
"@types/chalk": "^2.2.4",
6060
"@types/follow-redirects": "^1.14.4",
6161
"@types/js-yaml": "^4.0.9",

src/spec-node/dockerCompose.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ while sleep 1 & wait $$!; do :; done", "-"${userEntrypoint.map(a => `, ${JSON.st
557557
init: true` : ''}${user ? `
558558
user: ${user}` : ''}${Object.keys(env).length ? `
559559
environment:${Object.keys(env).map(key => `
560-
- '${key}=${env[key].replace(/\n/g, '\\n').replace(/\$/g, '$$$$').replace(/'/g, '\'\'')}'`).join('')}` : ''}${mergedConfig.privileged ? `
560+
- '${key}=${String(env[key]).replace(/\n/g, '\\n').replace(/\$/g, '$$$$').replace(/'/g, '\'\'')}'`).join('')}` : ''}${mergedConfig.privileged ? `
561561
privileged: true` : ''}${capAdd.length ? `
562562
cap_add:${capAdd.map(cap => `
563563
- ${cap}`).join('')}` : ''}${securityOpts.length ? `

src/spec-node/singleContainer.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -409,6 +409,7 @@ while sleep 1 & wait $!; do :; done`, '-']; // `wait $!` allows for the `trap` t
409409
...getLabels(labels),
410410
...containerEnv,
411411
...containerUserArgs,
412+
...getPodmanArgs(params),
412413
...(config.runArgs || []),
413414
...(await extraRunArgs(common, params, config) || []),
414415
...featureArgs,
@@ -433,6 +434,13 @@ while sleep 1 & wait $!; do :; done`, '-']; // `wait $!` allows for the `trap` t
433434
common.output.stop(text, start);
434435
}
435436

437+
function getPodmanArgs(params: DockerResolverParameters): string[] {
438+
if (params.isPodman && params.common.cliHost.platform === 'linux') {
439+
return ['--security-opt', 'label=disable', '--userns=keep-id'];
440+
}
441+
return [];
442+
}
443+
436444
function getLabels(labels: string[]): string[] {
437445
let result: string[] = [];
438446
labels.forEach(each => result.push('-l', each));

0 commit comments

Comments
 (0)