Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rating notification for multiple conferences #178

Open
abhinayagarwal opened this issue Oct 22, 2018 · 0 comments
Open

Fix rating notification for multiple conferences #178

abhinayagarwal opened this issue Oct 22, 2018 · 0 comments

Comments

@abhinayagarwal
Copy link
Collaborator

The way rating works now is that when the user selects a conference, it sets a local notification to remind the user to rate the app at the end of the conference. Once the notification is delivered, the user is taken the Sessions view when they tap on the notification.

The end of the conference can be days or weeks away. If the user switches conference in between this time, the rating notification will still be delivered, but the user taps on the notification, the session view won't show a rating dialog. The dialog will be shown if the user switches and goes back to the conference for which the notification was delivered.

This is because the show rating logic and notification logic are different.

We need a way to fix this.

@abhinayagarwal abhinayagarwal changed the title Fix rating botification for multiple conferences Fix rating notification for multiple conferences Oct 22, 2018
abhinayagarwal added a commit to abhinayagarwal/MyDevoxxGluon that referenced this issue Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant