Fix escaping multiple double quotes

zordius/lightncandy#298

Author: theodorejb

src/Parser.php

@@ -76,7 +76,8 @@ protected static function getExpression(string $v, Context $context, int|string
 
         // handle double-quoted string
         if (preg_match('/^"(.*)"$/', $v, $matched)) {
-            return static::getLiteral(preg_replace('/([^\\\\])\\\\\\\\"/', '$1"', preg_replace('/^\\\\\\\\"/', '"', $matched[1])), $asis, true);
+            $literal = str_replace('\\\\"', '"', $matched[1]);
+            return static::getLiteral($literal, $asis, true);
         }
 
         // handle single quoted string
@@ -150,18 +151,16 @@ protected static function getExpression(string $v, Context $context, int|string
     public static function parse(array $token, Context $context): array
     {
         $vars = static::analyze($token[Token::POS_INNERTAG], $context);
+        $avars = static::advancedVariable($vars, $context, Token::toString($token));
+
         if ($token[Token::POS_OP] === '>') {
             $fn = static::getPartialName($vars);
+            if ($fn !== null) {
+                $avars[0] = $fn;
+            }
         } elseif ($token[Token::POS_OP] === '#*') {
             $fn = static::getPartialName($vars, 1);
-        }
-
-        $avars = static::advancedVariable($vars, $context, Token::toString($token));
-
-        if (isset($fn)) {
-            if ($token[Token::POS_OP] === '>') {
-                $avars[0] = $fn;
-            } elseif ($token[Token::POS_OP] === '#*') {
+            if ($fn !== null) {
                 $avars[1] = $fn;
             }
         }

tests/RegressionTest.php

@@ -1333,6 +1333,19 @@ public static function issueProvider(): array
                 'expected' => 'foo " ',
             ],
 
+            [
+                'id' => 298,
+                'template' => '{{test "\"\"\"" prop="\"\"\""}}',
+                'options' => new Options(
+                    helpers: [
+                        'test' => function ($arg1, HelperOptions $options) {
+                            return "{$arg1} {$options->hash['prop']}";
+                        },
+                    ],
+                ),
+                'expected' => '""" """',
+            ],
+
             [
                 'id' => 302,
                 'template' => "{{#*inline \"t1\"}}{{#if imageUrl}}<span />{{else}}<div />{{/if}}{{/inline}}{{#*inline \"t2\"}}{{#if imageUrl}}<span />{{else}}<div />{{/if}}{{/inline}}{{#*inline \"t3\"}}{{#if imageUrl}}<span />{{else}}<div />{{/if}}{{/inline}}",