Split js 2 (netdata#4581)

* Mild cleanup of dashboard.js (netdata#4461)

* Balancing of else clauses

* More cleanup, fixed nasty bug introduced by previous commit

* More cleanup

* More refactoring

* Wip

* More refactoring

* Wip

* Cleanup, wip

* Refactor for-loop

* Remove .hasOwnProperties, wip

* Split dashboard.js into multiple files, wip netdata#4479

* Fixed a bug in common min/max

* Extracted more files from dashboard.js

* Extracted more code, wip

* Extract units-conversion.js and sparkline.js

* Do not include morris.js, c3.js and raphael.js in dashbaord.js

They are extracted as separate files but not included in dashboards.js

* Removed refs to obsolete charting libraries netdata#4492

* Extracted google-charts netdata#4479

* Extracted google-charts

* Extracted more charting libraries, cleanup

* Organize charting libs in subfolder

* Apply WebStorm formatter (mostly adds missing braces)

* Additional formatting with WebStorm netdata#4461

* Extracted d3pie, peity, localstorage

* Extracted options.js, fixed some issues with dependencies, wip

* Extracted boot.js

* Fixes in for loops netdata#4461

* Removed extrtacted d3pie from main file

* Extracted registry.js

* Extracted alarms.js

* Extracted error-handling.js

* Extracted fast formatting to utils.js

* Extracted chart libraries registration code

* Extracted some js/css loading code into boot.js

* Added some info on generating dashboard.js

* Fixed issues reported by LGTM

* added slitted dashboard.js to makefiles

* Minor

* Please keep build-dashboard-js

It's useful during development, I will clean this up in the mid-term

* Moved server-detection to utils

* Extracted themes.js

* Extracted common.js

* Extracted dependencies.js

* Extracted server-detection.js

* Extracted timeout.js

* Extracted chart-registry.js

* Remove excessive requestAnimationFrame compat checks, fixes netdata#4501

* Remove that == this netdata#4514

* Wip, netdata#4514

* Wip, netdata#4514

* More that -> this conversions

* Configure LGTM to ignore web/gui/src netdata#4515

* (x === false) -> (!x) netdata#4461

* Cleaned up commented === false clauses

* Properly configure LGTM to ignore web/gui/src netdata#4515

* Snake-case to camel-case netdata#4509

* wip netdata#4509

* Minor

* Updated Makefile.am

* Case changes, wip netdata#4509

* Removed double underscores

* Wip netdata#4509

* Wip netdata#4509

* merged dashboard.js

* deleted build-dashboard-js.sh

Author: gmosx

.lgtm.yml

@@ -18,6 +18,7 @@ path_classifiers:
     - collectors/node.d.plugin/node_modules/net-snmp.js
     - collectors/node.d.plugin/node_modules/pixl-xml.js
     - web/gui/lib/
+    - web/gui/src/
     - web/gui/css/
   test:
     - tests/

web/gui/Makefile.am

@@ -11,13 +11,17 @@ CLEANFILES = \
 DASHBOARD_JS_FILES = \
     src/dashboard.js/prologue.js.inc \
     src/dashboard.js/utils.js \
+    src/dashboard.js/server-detection.js \
+    src/dashboard.js/dependencies.js \
     src/dashboard.js/error-handling.js \
     src/dashboard.js/compatibility.js \
     src/dashboard.js/xss.js \
     src/dashboard.js/colors.js \
     src/dashboard.js/units-conversion.js \
     src/dashboard.js/options.js \
     src/dashboard.js/localstorage.js \
+    src/dashboard.js/timeout.js \
+    src/dashboard.js/themes.js \
     src/dashboard.js/charting/dygraph.js \
     src/dashboard.js/charting/sparkline.js \
     src/dashboard.js/charting/google-charts.js \
@@ -27,6 +31,8 @@ DASHBOARD_JS_FILES = \
     src/dashboard.js/charting/d3.js \
     src/dashboard.js/charting/peity.js \
     src/dashboard.js/charting.js \
+    src/dashboard.js/chart-registry.js \
+    src/dashboard.js/common.js \
     src/dashboard.js/main.js \
     src/dashboard.js/alarms.js \
     src/dashboard.js/registry.js \