Skip to content

Incorrect Group Handling in RequestContextHandler Causing Missing Context Attributes #4081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 tasks done
alihasan070707 opened this issue Apr 8, 2025 · 0 comments · May be fixed by #4082
Open
3 tasks done

Incorrect Group Handling in RequestContextHandler Causing Missing Context Attributes #4081

alihasan070707 opened this issue Apr 8, 2025 · 0 comments · May be fixed by #4082

Comments

@alihasan070707
Copy link

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I am not looking for support or already pursued the available support channels without success.

Version

2.42.0

Storage Type

etcd

Installation Type

Custom container image

Expected Behavior

When using WithGroup to nest log attributes, the requestContextHandler wrapper is bypassed, it will cause request context attributes (remote_ip, request_id) to be omitted from grouped log entries.

/cmd/dex/logger.go

Actual Behavior

attributes (remote_ip, request_id) are not present in log messages.

Steps To Reproduce

use WithGroup to nest log attributes.

Additional Information

No response

Configuration



Logs



      		
    

      
  





        



            
            

              
            

        

      


      
    








      

    



      

  
          


  
    
  
  

    
  alihasan070707 

      added a commit
        to alihasan070707/dex
      that referenced
      this issue

    
      Apr 8, 2025
    
      
        
      
    

      


  

    

      


  

      
        @alihasan070707
  





      

        
          fix Incorrect Group Handling in RequestContextHandler logger.go
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          804883f
        
      

    

  

    

      
Wrap the grouped handler in requestContextHandler to preserve context attribute injection.
fixes dexidp#4081

Signed-off-by: alihasan070707 <[email protected]>

    




    

  




  

  

    
  


  

      

    @alihasan070707
alihasan070707



    linked a pull request
    
      Apr 8, 2025
    

    that will
    close
    this issue





  


  

      
   Open

  







  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
    

    Development
  




            
  
Successfully merging a pull request may close this issue.





    


  
          
      fix Incorrect Group Handling in RequestContextHandler logger.go

    
      alihasan070707/dex
    





      
    

  




      

    

  
      

  

    

      1 participant
    

    

        
          @alihasan070707