Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to the correct start and end indices #1271

Closed
wants to merge 3 commits into from

Conversation

zhenyanghua
Copy link

This fixes the chunk being sliced to its own copy.

@dfahlander
Copy link
Collaborator

Thanks @zhenyanghua for the PR!

I see the test did fail for this fix. The reason might be an error in the test itself.

To understand what issue is being fixed, please file an issue that describes it. Also, it would be great if you could add another promisedTest() in basic-tests.ts or edge-cases.ts that reproduces the issue with the existing code. You could do that in this ongoing PR and refer to it from your issue.

@zhenyanghua
Copy link
Author

The edge tests failed on CI (even locally all tests pass) due to:

✖ chunkedExport (issue #854)
Firefox 85.0 (Linux x86_64)
Got error: NotReadableError: File could not be read
NotReadableError: File could not be read

From MDN, it says:

The file or directory cannot be read, typically due to permission problems that occur after a reference to a file has been acquired (for example, the file or directory is concurrently locked by another application).

I suspect it may be this operation that puts the file on lock:

https://github.com/dfahlander/Dexie.js/blob/b6d621ef25075f4f54cfdd923834bf939351cd93/addons/dexie-export-import/src/tson.ts#L60

@dfahlander I am puzzled now with this issue. Do you have any thoughts on the issue?

@dfahlander
Copy link
Collaborator

Closing. PR too old.

@dfahlander
Copy link
Collaborator

The changes in this PR has was tweaked and applied in #2094 and merged into master today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants