EES-5496 Fix inconsistent anchor IDs causing broken nav links in API data set mapping pages #5481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsim
changed the title
...re-education-statistics-admin/src/pages/release/data/ReleaseApiDataSetFiltersMappingPage.tsx
Show resolved
Hide resolved
...re-education-statistics-admin/src/pages/release/data/ReleaseApiDataSetFiltersMappingPage.tsx
Show resolved
Hide resolved
...re-education-statistics-admin/src/pages/release/data/ReleaseApiDataSetFiltersMappingPage.tsx
Show resolved
Hide resolved
...e-education-statistics-admin/src/pages/release/data/components/ApiDataSetAutoMappedTable.tsx
Show resolved
Hide resolved
tests/robot-tests/tests/public_api/public_api_minor_manual_changes.robot
Show resolved
Hide resolved
duncan-at-hiveit
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes inconsistent anchor IDs being used across the the public API filters and locations mapping pages. Previously, we were using hard-coded ID strings meaning that it was easy to forget to update them in all places. This would then lead to broken navigation links due to stale IDs being used.
We've not refactored both the filters and locations mappings pages to use common variables and functions to generate the necessary anchor IDs. This should hopefully keep things consistent and less bug-prone moving forward.