Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up CSS and move out of template #102

Open
cjrace opened this issue Dec 8, 2024 · 0 comments
Open

Tidy up CSS and move out of template #102

cjrace opened this issue Dec 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@cjrace
Copy link
Contributor

cjrace commented Dec 8, 2024

We currently have one long custom CSS file to style the dashboard. Though we should try to clean this up / get rid of what isn't needed anymore:

Remove all unnecessary CSS from www/dfe_shiny_gov_style.css without altering the appearance of the app by...

  1. Make use of what is already attached in shinyGovstyle from the GDS design system, using functions like gov_text() to pull it in instead of relying on a CSS file in the repo

  2. Move any CSS for specific components that remains into the dfeshiny package, attached to those specific components

Remove as many instances of !important as we can

  • !important is generally bad practice, and can usually be avoided by using the appropriate specificity for the CSS assignments
@cjrace cjrace added the enhancement New feature or request label Dec 8, 2024
@cjrace cjrace added this to the Accessibility UI refresh milestone Dec 8, 2024
@cjrace cjrace changed the title Modularise and tidy up CSS Tidy up CSS and move out of template Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant