105 update to latest govuk frontend version #117
Conversation
There was a problem hiding this comment.
Not fully tested everything, but leaving the comments I have for now so they're not lost (as I'm not around tomorrow)
Spotted an issue with accordions (though not cross checked against main yet to see if it's pre-existing)
- Only the 'show' is clickable, if you click on the title of the accordion it doesn't open, though for GDS component it seems like clicking anywhere around the accordion title should also open it? https://design-system.service.gov.uk/components/accordion/
inst/www/images/govuk-crest.svg
Outdated
There was a problem hiding this comment.
Do we use this anywhere? Looks like the footer crest, though seems odd we didn't already have a version of it? Do we need to point the footer function this this?
There was a problem hiding this comment.
yes this replaces govuk-crest.png, still sat in the folder here weirdly! I'll double check when I'm back on my personal comp whether this image was removed in the latest zip file or not, and see if we can remove. Footer function points to govuk-footer__copyright-logo in the css which has the right svg file referenced so no need to update I think
There was a problem hiding this comment.
Given we just copy this in now (and we are full rem instead of norem), would it make sense to change to leaving the name as the same as the one from the GOV.UK ZIP? I think then it's just a case of updating the attach function to import this sheet as a dependency?
| @@ -1,8 +1,7 @@ | |||
| @charset "UTF-8"; | |||
|
|
|||
| :root { | |||
| --govuk-frontend-version: "5.4.0"; | |||
| font-size: 16px; | |||
There was a problem hiding this comment.
Was removing this font size a GDS or us change? I think a lot of the fonts all seem smaller now than they were?
Screenshot from this branch (100% zoom in Chrome):
Screenshot from the master branch (100% zoom in Chrome):
|
Thanks for your comments @cjrace! I think these have been addressed now - think the font fix fixes the selection box (looks like this to me): Accordions issue is pre-existing in master good spot! I've raised #123 for a fix - can ask Jeni to take a look unless you wanted to have a go with faffing with the JS! 😄 |
Overview of changes
Update to 5.7.1 frontend - adding @cjrace as a reviewer as you've had experience updating this before too!
Everything looks ok apart from value boxes - tested this in master and still looks odd! I've raised #116 for Andy to revisit as this looks like a separate issue.
Removed some old manual changes from the css_changes.md file as no longer relevant
PR Checklist
devtools::check()Reviewer instructions
Run devtools::load_all
Run run_example()
Check that all css changes look ok and functionality still works