Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value boxes rendering oddly #116

Open
1 of 3 tasks
sarahmwong opened this issue Dec 6, 2024 · 1 comment
Open
1 of 3 tasks

Value boxes rendering oddly #116

sarahmwong opened this issue Dec 6, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@sarahmwong
Copy link
Collaborator

sarahmwong commented Dec 6, 2024

Overview

  • - Value boxes are not rendering as expected, taking up the full width of page.

  • - The example at the top of the R script also needs changing from value_text to value_box

  • - The PNG image for the README is not there - please can you upload once the above is fixed too? 😄

How to reproduce

Steps to reproduce the behaviour:

  1. Run devtools::load_all()
  2. Run run_example()
  3. Click through to value boxes

Expected behaviour

Value box appears, clear space defined between each box, ability to set width and height of box - possibly using width classes (this is new functionality but would be good if possible!)? https://design-system.service.gov.uk/styles/layout/#width-override-classes

Screenshots

Additional context

This was working as expected before! Not sure what has crept in to cause the error here - hopefully a case of tracking back through your code :)

@sarahmwong
Copy link
Collaborator Author

@AndyABaker reran on master, both Cam and I cant replicate this now! Think the other two minor issues still need adding though when you have time - sorry for any confusion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants