Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the dropdown (select) function for accessibility #61

Open
cjrace opened this issue Apr 18, 2024 · 0 comments
Open

Test the dropdown (select) function for accessibility #61

cjrace opened this issue Apr 18, 2024 · 0 comments
Labels
testing Needs testing, possibly more issues to raise from this

Comments

@cjrace
Copy link
Collaborator

cjrace commented Apr 18, 2024

We had a recent accessibility audit at DfE that highlighted a few issues with standard shiny dropdown selectors. We should review whether the select function in this package would solve those issues by testing the test / template app ourselves. I believe it should, though not all GDS components are fully accessible, so this is worth checking specifically as a part of the upgrade to v5+ of the frontend system.

Examples of issues with other dropdowns we should test:

  • Having a visual label marked up
  • Having a non-visual label marked appropriately
  • Appropriate contrast on focus

I have specific examples I can share on this to have a look at from our accessibility audit.

@sarahmwong sarahmwong added the testing Needs testing, possibly more issues to raise from this label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Needs testing, possibly more issues to raise from this
Projects
None yet
Development

No branches or pull requests

2 participants