Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the way logos and text are added to the header #63

Open
cjrace opened this issue Apr 18, 2024 · 1 comment · May be fixed by #121
Open

Review the way logos and text are added to the header #63

cjrace opened this issue Apr 18, 2024 · 1 comment · May be fixed by #121
Assignees
Labels
bug Something isn't working

Comments

@cjrace
Copy link
Collaborator

cjrace commented Apr 18, 2024

We had some issues with dashboards that had inserted the DfE logo into the header function, around contrast styles. Not sure if it's an error that was made when creating the dashboard or not, though should review how the function works and if there's anything we can do in this package to help prevent it happening.

image

A second issue was also identified around a lack of descriptive text for the links out of the header.

I have specific examples I can share on this to have a look at from our accessibility audit.

@sarahmwong sarahmwong added the bug Something isn't working label Apr 29, 2024
@mzayeddfe mzayeddfe self-assigned this Dec 11, 2024
@mzayeddfe mzayeddfe linked a pull request Dec 12, 2024 that will close this issue
@mzayeddfe mzayeddfe linked a pull request Dec 12, 2024 that will close this issue
@mzayeddfe
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants