Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to add links into the footer #77

Open
cjrace opened this issue May 11, 2024 · 1 comment · May be fixed by #114
Open

Add ability to add links into the footer #77

cjrace opened this issue May 11, 2024 · 1 comment · May be fixed by #114
Assignees
Labels
enhancement New feature or request

Comments

@cjrace
Copy link
Collaborator

cjrace commented May 11, 2024

There's a few examples of this starting to appear, e.g. on Explore education statistics we add a line about OSR and also links to various pages from the footer.

image

The UKHSA dashboard also does the same.

image

We can use the govuk-footer__inline-list class for this, and should make sure to give the option for a visually hidden heading that screen readers can use to navigate to these.

When we do this change, we should also add .noWS = "after" to the a tag for Open Government Licence as you can now remove the excess whitespace it adds pretty easily.

Example of current footer with whitespace is visible on the README
image

@cjrace cjrace added the enhancement New feature or request label May 28, 2024
@cjrace
Copy link
Collaborator Author

cjrace commented Aug 16, 2024

Have an in progress version of this in https://github.com/dfe-analytical-services/apprenticeships-provider-dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants