Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move run_example to own directory #120

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cjrace
Copy link
Collaborator

@cjrace cjrace commented Dec 11, 2024

Overview of changes

After #118 failed, I'm now going for the bigger change of creating a separate directory for the run_example() app, so I have a directory I can point shinyapps.io to for the deployment. Have been following the notes in a shinytest2 vignette. Hoping this approach should work...

Relates to #110 but won't necessarily resolve it - I will need to check that after it goes into master.

run_example() still runs the example app.

PR Checklist

  • I have updated the documentation (if needed)
  • I have added or updated tests for these changes (if applicable)
  • I have tested these changes locally using devtools::check()

Reviewer instructions

I copied the contents of run_example into an app.R file in it's own directory so nothing material should have change in the example app (aside from the note around where to find the code).

Main thing is to check that run_example() still opens an app for you, and that the package checks pass

@cjrace cjrace requested a review from sarahmwong December 11, 2024 18:40
@cjrace cjrace added the enhancement New feature or request label Dec 11, 2024
Copy link
Collaborator

@sarahmwong sarahmwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cam! App runs fine with run_example() and devtools::check() passes all tests for me.

devtools::test() I get some errors though - cant find the skip_to_main() function, also skips the tests for testing the example app, can see it's meant to skip on CRAN but is this expected behaviour here? I have also just updated R on my mac so may be a me problem! I'll let you know if that turns out to be the case in this thread, but do you get the same errors? image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants