Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which files are cleaned? #19

Open
staabm opened this issue Oct 20, 2018 · 5 comments
Open

Which files are cleaned? #19

staabm opened this issue Oct 20, 2018 · 5 comments

Comments

@staabm
Copy link

staabm commented Oct 20, 2018

Would be great to have a few examples or similar of files which this plugins will delete and why...

@glensc
Copy link

glensc commented Aug 31, 2019

Yeah, wondered that too, as it's not described at all in the readme. but reading source code of the plugin seems all files that are not defined as an autoloader, get removed, with some hard coded defaults that are never removed.

First I liked the idea that it's done this way, that doesn't have to inspect every package to see what to cleanup, but reading #16 seems this could be a problem for packages that bundle more than PHP sources.

@dg
Copy link
Owner

dg commented Aug 31, 2019

I have added more information to the readme.

@glensc
Copy link

glensc commented Aug 31, 2019

(for posterity) link to above changes ac989d0

@glensc
Copy link

glensc commented Aug 31, 2019

does the cleaner support extra.cleaner-ignore from the vendored project composer.json as well? as it would more sense to submit those to upstream projects.

but then again the upstream projects can use .gitattributes if they care about the problem and then cleaner does not need to do that:

in such case those projects should be skipped, perhaps the introduce new key which projects indicate they do not need cleaning (but package extra runtime files required).

@glensc
Copy link

glensc commented Aug 31, 2019

aside, maybe introduce commandline support here? to be run manually, i.e when producing release tarball. I'm currently cleaning the vendor using whitelisted patterns to delete. whitelist because not to break every new dependency without analyze what is needed for runtime:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants