Skip to content

Commit 5f4e27f

Browse files
authored
Merge pull request #20 from trym-moeller/upgrade-libthrift
Upgrade libthrift
2 parents 4e80f00 + 8f3cd87 commit 5f4e27f

File tree

4 files changed

+15
-10
lines changed

4 files changed

+15
-10
lines changed

pom.xml

+12-6
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
<dependency>
4646
<groupId>org.apache.thrift</groupId>
4747
<artifactId>libthrift</artifactId>
48-
<version>0.12.0</version>
48+
<version>0.20.0</version>
4949
</dependency>
5050
<dependency>
5151
<groupId>commons-lang</groupId>
@@ -57,11 +57,16 @@
5757
<artifactId>guava</artifactId>
5858
<version>19.0</version>
5959
</dependency>
60-
<dependency>
61-
<groupId>javax.annotation</groupId>
62-
<artifactId>javax.annotation-api</artifactId>
63-
<version>1.3.2</version>
64-
</dependency>
60+
<dependency>
61+
<groupId>javax.annotation</groupId>
62+
<artifactId>javax.annotation-api</artifactId>
63+
<version>1.3.2</version>
64+
</dependency>
65+
<dependency>
66+
<groupId>org.slf4j</groupId>
67+
<artifactId>slf4j-api</artifactId>
68+
<version>1.7.35</version>
69+
</dependency>
6570
</dependencies>
6671

6772

@@ -100,6 +105,7 @@
100105
<plugin>
101106
<groupId>org.apache.maven.plugins</groupId>
102107
<artifactId>maven-javadoc-plugin</artifactId>
108+
<version>3.11.2</version>
103109
<executions>
104110
<execution>
105111
<id>attach-javadocs</id>

thrift-mock-server/src/main/java/com/didiglobal/thriftmock/server/AsyncThriftMockServer.java

-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import org.apache.thrift.TProcessor;
66
import org.apache.thrift.server.TNonblockingServer;
77
import org.apache.thrift.server.TServer;
8-
import org.apache.thrift.transport.TFramedTransport;
98
import org.apache.thrift.transport.TNonblockingServerSocket;
109
import org.apache.thrift.transport.TTransportException;
1110
import org.slf4j.Logger;
@@ -40,7 +39,6 @@ public void start() {
4039
TNonblockingServer.Args serverArgs = new TNonblockingServer.Args(serverTransport);
4140
serverArgs.processor(tProcessor);
4241
serverArgs.protocolFactory(serverConfig.getTProtocolFactory());
43-
serverArgs.transportFactory(new TFramedTransport.Factory());
4442
tServer = new TNonblockingServer(serverArgs);
4543
tServer.serve();
4644
}

thrift-mock-server/src/main/java/com/didiglobal/thriftmock/server/ProcessFunctionMock.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,6 @@ public TBase getResult(Object iface, TBase args) throws TException {
6565

6666
@Override
6767
public TBase getEmptyArgsInstance() {
68-
return isPrimitive ? mockResultFunction.apply(args) : new MockResult(methodName, mockResultFunction.apply(args));
68+
return args;
6969
}
7070
}

thrift-mock-test-source/src/main/java/com/didiglobal/thriftmock/test/source/TProtocolUtil.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.didiglobal.thriftmock.test.source;
22

33

4+
import org.apache.thrift.TConfiguration;
45
import org.apache.thrift.protocol.TBinaryProtocol;
56
import org.apache.thrift.protocol.TProtocol;
67
import org.apache.thrift.transport.TSocket;
@@ -22,7 +23,7 @@ public static TProtocol initTProtocol(String host, int port,
2223
if (timeout == null || timeout <= 0){
2324
transport = new TSocket(host, port);
2425
} else {
25-
transport = new TSocket(host, port, timeout);
26+
transport = new TSocket(new TConfiguration(), host, port, timeout);
2627
}
2728
transport.open();
2829
return new TBinaryProtocol(transport);

0 commit comments

Comments
 (0)