Rename obj variables #558
Open
Rename obj variables #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did not change obj variables if they can be more than a single model type. Also instances of `obj` variables in methods that overwrite a super method are kept the same.
david-venhoff
commented
Feb 12, 2025
Comment on lines
-35
to
-36
| :param disc: Discipline instance | ||
| :type disc: ~lunes_cms.cms.models.discipline.Discipline |
There was a problem hiding this comment.
I am pretty sure that this is a copy-and-paste error from the discipline_serializer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pr renames
objvariables to be more descriptive.I did not change obj variables if they can be more than a single
model type.
Also instances of
objvariables in methods that overwrite asuper method are kept the same.
Proposed changes
Resolved issues
Fixes: #514