admission-controller-webhook-replacement check needs more details

[varshavaradarajan]

This check just outputs that the webhook is configured incorrectly and can cause problems with DOKS cluster upgrades. But, adding in more details as to how the webhook is configured wrong or what config changes can be done to fix it will help users more.

Context: https://kubernetes.slack.com/archives/CCPETNUCA/p1598549516051000

This check can also use more test cases that can cause it to fail. This also serves as documentation for anyone trying to understand how their webhook config can cause the check to fail.

[devurandom]

Is this about updates to the cluster using the UI at https://cloud.digitalocean.com/kubernetes/clusters/... producing errors:

• Validating webhook is configured in such a way that it may be problematic during upgrades.
• Mutating webhook is configured in such a way that it may be problematic during upgrades.

which link to https://www.digitalocean.com/docs/kubernetes/resources/clusterlint-errors#admission-controller-webhook-replacement, but that section not existing?

[varshavaradarajan]

@devurandom - thanks for your interest! Yes, those are the errors that we have got feedback from DOKS users from. Basically to add more details so users can figure out how to fix the config.

The link is https://www.digitalocean.com/docs/kubernetes/resources/clusterlint-errors/#admission-controller-webhook - we are updating the docs to have the right check name.

[fish-dango]

Hello again @varshavaradarajan!

This issue has been up a while. Just wondering if it is still being worked on? I was interested in trying to help here :)

[varshavaradarajan]

@fish-dango - no, it's available for you to pick up. :)