Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using separate structs for the Controller and Node parts #207

Open
timoreimann opened this issue Nov 8, 2019 · 0 comments
Open
Labels
good first issue Good for newcomers

Comments

@timoreimann
Copy link
Contributor

Our Controller and Node plugin parts currently share the same underlying Driver struct. While this keeps things fairly straight forward, it also makes it harder to understand which pieces are used where and complicates reasoning about the code in general.

For instance, the set of godo interfaces are not required by the Node part at all, while the mounter is only needed by the Node part. Yet, both are available to the Controller and the Node parts.

We should consider creating separate structs (that embed a common struct as needed) and give each one just that the fields and methods that it needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant