Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other git providers #95

Open
FatihYalmanbas opened this issue Nov 5, 2020 · 0 comments
Open

Add support for other git providers #95

FatihYalmanbas opened this issue Nov 5, 2020 · 0 comments
Assignees
Labels
feature request Suggest an idea for this project
Milestone

Comments

@FatihYalmanbas
Copy link

Motivation
I would rather have repository-pr creation config to be abstracted so that I can use it for other git repository providers too. (Bitbucket, GitHub, GitLab, Internal git repository)

Possible Solution:
Maybe start with extracting github related parameters and PR checking logic to another class.
Maybe an extension called vcsProvider, where github is a function to preconfigure it. Just like mavenCentral in RepositoryHandler.
Then create a task for each repository configured in vcsProvider and make them depend on upgradeDependencies task. Can be named "upgradeDependenciesFor$vcsProviderName"

vcsProvider {
   github {
       token = ""
   }
}

Alternative to consider:
Maybe creating an output so other plugins or scripts can depend on this plugin to create their own logic. Such as uploading it to an internal server or in this case upgrading application dependencies and creating their own pr.

@FatihYalmanbas FatihYalmanbas added the feature request Suggest an idea for this project label Nov 5, 2020
@maxirosson maxirosson added this to the v1.7.0 milestone Nov 6, 2020
@maxirosson maxirosson self-assigned this Nov 6, 2020
@maxirosson maxirosson modified the milestones: v1.7.0, v2.0.0 Dec 8, 2020
@maxirosson maxirosson modified the milestones: v2.0.0, v3.0.0 Mar 1, 2021
@maxirosson maxirosson modified the milestones: v3.0.0, v4.0.0, v5.0.0 Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Suggest an idea for this project
Development

No branches or pull requests

2 participants