Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assemble: use more templates to build example pages #22

Open
eins78 opened this issue Nov 5, 2013 · 2 comments
Open

Assemble: use more templates to build example pages #22

eins78 opened this issue Nov 5, 2013 · 2 comments

Comments

@eins78
Copy link
Contributor

eins78 commented Nov 5, 2013

I want to get some feedback on an idea before doing it:

How about we really use the available feature of assemble/mustache, apart from setting a few variables?

  • partials for header and footer
    • would make it easier to have a better navigation (for example the 'theme name' link in the navbar of kitchen-sink should go to index)
  • maybe splitting up the kitchen-sink in small components which are included
    • would it also more easy to exclude elements which are also excluded from bootstrap (depending on the theme it might make sense to not have alerts etc.)

I think that it would certainly clean up the example pages, making them more maintainable.

@trumbitta
Copy link
Contributor

I like the idea: it actually is something I quickly thought of sometimes.
It certainly would push the development cycle a step forward 👌

@eins78
Copy link
Contributor Author

eins78 commented Nov 5, 2013

Cool. I am playing around with the possibilities in a theme I am working on atm.
Will then report or backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants