-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari bug #40
Comments
Thx for the bug Pete. Most of this code was written by @p-realinho so let me check with him if there's an obvious solution |
Hi. I could take a look at the code, but I have no way to test this in Safari :/ |
Thanks @moeamaya @p-realinho. Attached is a screengrab of the issue in chrome vs safari. The rellax element is the yellow shard in the background. You can see the transform is quite far off in safari at the same page position (+1060px vs -30px). If there's any way I can help to isolate the issue please let me know. |
@moeamaya @Petemcd @p-realinho Only a nightly spontaneous idea: |
Hi @acki, sorry about the delay. I think that might be the issue. Here's a link to the test site (still needs some polishing 😅): http://terrydesign.co.uk/index.php/2017/index.html |
@Petemcd This is a super late reply and I know you've launched the site, but is this still an issue? |
Also encountering this issue in safari @Petemcd did you find a workaround for this? |
I'm also having this issue. @Petemcd @matteightarms did you guys ever find a workaround? |
@MrUltimate No I didn't sadly! Sorry. |
We recently experienced that issue, too. What solved it for us was using an Intersection Observer on all of the |
@MrUltimate @matteightarms @guidoschmidt Happy to accept a PR that addresses this. Unfortunately just too preoccupied with family and the day job at the moment. |
I've tried to understand the code of rellax.js a bit today. Really not sure, but it appears to me, that browsers differ in their way of returning Would be nice if someone could validate my suspicion and test is. I've also created a small test setup here: guidoschmidt/rellax.js.bug |
In Safari (currently 10.0.2), the initial rellax element positions are incorrectly calculated unless a height is specified on the preceding containers/divs. Consequently, the 3d transforms are centered around a co-ordinate that is too far down the page. The more content is placed before the rellax element, the greater the error in the initial position. Testing in Chrome, the initial positions are calculated correctly.
I'm using the centering option
var rellax = new Rellax('.rellax', {center: true});
Any ideas would be much appreciated.
The text was updated successfully, but these errors were encountered: