From 8e8096dbaf901d3c60c81140ca93bebabaadc781 Mon Sep 17 00:00:00 2001 From: Amanda Savluchinske Date: Mon, 18 Dec 2023 11:48:55 -0300 Subject: [PATCH 1/3] Deletes circleci folder and adds config.yml to GitHub workflows --- .circleci/config.yml | 46 -------------------- .github/ISSUE_TEMPLATE/workflows/config.yml | 48 +++++++++++++++++++++ 2 files changed, 48 insertions(+), 46 deletions(-) delete mode 100644 .circleci/config.yml create mode 100644 .github/ISSUE_TEMPLATE/workflows/config.yml diff --git a/.circleci/config.yml b/.circleci/config.yml deleted file mode 100644 index cbd4531..0000000 --- a/.circleci/config.yml +++ /dev/null @@ -1,46 +0,0 @@ -version: 2.1 - -jobs: - # This job is built separately because node <= 16 doesn't require - # (and will crash) if we use NODE_OPTIONS=--openssl-legacy-provider - # which is required for tests in more recent versions to work - test-node-16: - docker: - - image: cimg/node:16.20 - steps: - - checkout - - run: | - echo "Node version: $(node --version)" - echo "NPM version: $(npm --version)" - npm install - npm run ci - test: - parameters: - node-version: - type: string - docker: - - image: cimg/node:<< parameters.node-version >> - environment: - # Must be used for running the webpack@4 tests on node >= 17 - NODE_OPTIONS: --openssl-legacy-provider - steps: - - checkout - - run: | - echo "Node version: $(node --version)" - echo "NPM version: $(npm --version)" - npm install - npm run ci - -workflows: - all-tests: - jobs: - - test: - matrix: - parameters: - node-version: - - "current" - - "lts" - name: test-on-node-<< matrix.node-version >> - - test-node-16: - # Oldest maintenance LTS, End-of-Life 2023-09-11 - name: test-on-node-16.20 diff --git a/.github/ISSUE_TEMPLATE/workflows/config.yml b/.github/ISSUE_TEMPLATE/workflows/config.yml new file mode 100644 index 0000000..6579f73 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/workflows/config.yml @@ -0,0 +1,48 @@ +name: main + +on: + push: + branches: [ master ] + pull_request: + branches: [ master ] + +jobs: + # Oldest maintenance LTS, End-of-Life 2025-04-30 + test-node-18: + runs-on: ubuntu-latest + container: + image: node:18.19 + steps: + - name: Checkout + uses: actions/checkout@v2 + - name: Set up Node.js + run: | + echo "Node version: $(node --version)" + echo "NPM version: $(npm --version)" + npm install + npm run ci + + test: + runs-on: ubuntu-latest + strategy: + matrix: + node-version: + - "current" + - "lts" + env: + NODE_OPTIONS: --openssl-legacy-provider + steps: + - name: Checkout + uses: actions/checkout@v2 + - name: Set up Node.js + uses: actions/setup-node@v3 + with: + node-version: ${{ matrix.node-version }} + - name: Print Node.js version + run: | + echo "Node version: $(node --version)" + echo "NPM version: $(npm --version)" + - name: Install dependencies and run tests + run: | + npm install + npm run ci \ No newline at end of file From 3793feba54b700c44f7093d24d0db656349ed6b1 Mon Sep 17 00:00:00 2001 From: Amanda Savluchinske Date: Mon, 18 Dec 2023 11:54:10 -0300 Subject: [PATCH 2/3] Moves the workflows folder to the appropriate place --- .github/{ISSUE_TEMPLATE => }/workflows/config.yml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/{ISSUE_TEMPLATE => }/workflows/config.yml (100%) diff --git a/.github/ISSUE_TEMPLATE/workflows/config.yml b/.github/workflows/config.yml similarity index 100% rename from .github/ISSUE_TEMPLATE/workflows/config.yml rename to .github/workflows/config.yml From a3531f5479a56d419711eb0566c5e17554bea21d Mon Sep 17 00:00:00 2001 From: Amanda Savluchinske Date: Mon, 18 Dec 2023 12:34:32 -0300 Subject: [PATCH 3/3] Updates workflow with working version --- .github/workflows/config.yml | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/.github/workflows/config.yml b/.github/workflows/config.yml index 6579f73..c8c7a63 100644 --- a/.github/workflows/config.yml +++ b/.github/workflows/config.yml @@ -12,15 +12,20 @@ jobs: runs-on: ubuntu-latest container: image: node:18.19 + env: + NODE_OPTIONS: --openssl-legacy-provider steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Set up Node.js run: | echo "Node version: $(node --version)" echo "NPM version: $(npm --version)" npm install npm run ci + - name: Unset NODE_OPTIONS + run: | + unset NODE_OPTIONS test: runs-on: ubuntu-latest @@ -28,14 +33,14 @@ jobs: matrix: node-version: - "current" - - "lts" + - "20.10" env: NODE_OPTIONS: --openssl-legacy-provider steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Set up Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} - name: Print Node.js version @@ -45,4 +50,7 @@ jobs: - name: Install dependencies and run tests run: | npm install - npm run ci \ No newline at end of file + npm run ci + - name: Unset NODE_OPTIONS + run: | + unset NODE_OPTIONS \ No newline at end of file