From 135571db363f148ad9968219fa1731d64367d6f7 Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Sat, 19 Nov 2022 21:52:04 +0000 Subject: [PATCH] vuln-fix: Temporary File Information Disclosure This fixes temporary file information disclosure vulnerability due to the use of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by using the `Files.createTempFile()` method which sets the correct posix permissions. Weakness: CWE-377: Insecure Temporary File Severity: Medium CVSSS: 5.5 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/18 Co-authored-by: Moderne --- .../keyphrases/bookindexing/wrapper/TfidfExtractor.java | 5 +++-- .../ukp/dkpro/keyphrases/core/wrapper/TfidfExtractor.java | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/de.tudarmstadt.ukp.dkpro.keyphrases.wrappers-gpl/src/main/java/de/tudarmstadt/ukp/dkpro/keyphrases/bookindexing/wrapper/TfidfExtractor.java b/de.tudarmstadt.ukp.dkpro.keyphrases.wrappers-gpl/src/main/java/de/tudarmstadt/ukp/dkpro/keyphrases/bookindexing/wrapper/TfidfExtractor.java index 53989fb..2b811af 100644 --- a/de.tudarmstadt.ukp.dkpro.keyphrases.wrappers-gpl/src/main/java/de/tudarmstadt/ukp/dkpro/keyphrases/bookindexing/wrapper/TfidfExtractor.java +++ b/de.tudarmstadt.ukp.dkpro.keyphrases.wrappers-gpl/src/main/java/de/tudarmstadt/ukp/dkpro/keyphrases/bookindexing/wrapper/TfidfExtractor.java @@ -14,6 +14,7 @@ import java.io.File; import java.io.IOException; +import java.nio.file.Files; import org.apache.uima.analysis_engine.AnalysisEngineDescription; import org.apache.uima.resource.ResourceInitializationException; @@ -78,7 +79,7 @@ public void buildTfidfModel(File inputDir, String suffix) try { final DfModelBuilder dfModelBuilder = new DfModelBuilder(getLanguage(), inputDir, suffix); - File tmpFile = File.createTempFile("tfidf_model_ukp", "tmp"); + File tmpFile = Files.createTempFile("tfidf_model_ukp", "tmp").toFile(); dfModelBuilder.buildKeyphraseCandidateModel(getCandidateSet(), tmpFile); tfidfModelFile = tmpFile; } @@ -144,4 +145,4 @@ TfidfAnnotator.PARAM_IDF_MODE, getIdfWeightingMode().name()), TfidfRanking.PARAM_AGGREGATE,TfidfRanking.TfidfAggregate.max.name())); } -} \ No newline at end of file +} diff --git a/de.tudarmstadt.ukp.dkpro.keyphrases.wrappers-gpl/src/main/java/de/tudarmstadt/ukp/dkpro/keyphrases/core/wrapper/TfidfExtractor.java b/de.tudarmstadt.ukp.dkpro.keyphrases.wrappers-gpl/src/main/java/de/tudarmstadt/ukp/dkpro/keyphrases/core/wrapper/TfidfExtractor.java index 884031a..acc97f3 100644 --- a/de.tudarmstadt.ukp.dkpro.keyphrases.wrappers-gpl/src/main/java/de/tudarmstadt/ukp/dkpro/keyphrases/core/wrapper/TfidfExtractor.java +++ b/de.tudarmstadt.ukp.dkpro.keyphrases.wrappers-gpl/src/main/java/de/tudarmstadt/ukp/dkpro/keyphrases/core/wrapper/TfidfExtractor.java @@ -14,6 +14,7 @@ import java.io.File; import java.io.IOException; +import java.nio.file.Files; import org.apache.uima.analysis_engine.AnalysisEngineDescription; import org.apache.uima.collection.CollectionReaderDescription; @@ -97,7 +98,7 @@ TfidfAnnotator.PARAM_IDF_MODE, getIdfWeightingMode().name()), */ public void buildTfidfModel(File inputDir, String suffix) throws ResourceInitializationException { try { - File tmpFile = File.createTempFile("tfidf_model_ukp", "tmp"); + File tmpFile = Files.createTempFile("tfidf_model_ukp", "tmp").toFile(); buildTfidfModel(inputDir, suffix, tmpFile); } catch (Exception e) { @@ -203,4 +204,4 @@ public File getTfidfModelFile() { return tfidfModelFile; } -} \ No newline at end of file +}