Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong syntax highlight / indentation for nestable multi line comments #761

Open
Geod24 opened this issue Oct 30, 2020 · 9 comments
Open

Comments

@Geod24
Copy link
Member

Geod24 commented Oct 30, 2020

// Single line
/* Multi
Line
Comment
*/
/+ Nestabled
/+
Multi
/+
Line
+/ Comment +/ +/
    void main () {}

Looks like the issue is present on Github as well... So I guess it's @jacob-carlborg 's territory ?

Screen Shot 2020-10-30 at 14 50 27

@jacob-carlborg
Copy link

I can reproduce it in TextMate as well. I created an issue in the D bundle repository: textmate/d.tmbundle#20. I'll take a look when I have some time.

@jacob-carlborg
Copy link

Fixed in the TextMate bundle: textmate/d.tmbundle#20. I don't know how the procedure for updating the bundle used by GitHub works.

@wilzbach
Copy link
Member

wilzbach commented Nov 3, 2020

Fixed in the TextMate bundle: textmate/d.tmbundle#20. I don't know how the procedure for updating the bundle used by GitHub works.

https://github.com/github/linguist/blob/master/CONTRIBUTING.md#fixing-syntax-highlighting
https://github.com/github/linguist/tree/master/vendor

Last update was in June though: github-linguist/linguist#4881

@wilzbach
Copy link
Member

wilzbach commented Nov 3, 2020

@Geod24
Copy link
Member Author

Geod24 commented Nov 6, 2020

Regarding Github, we might be lucky: github-linguist/linguist#5084 :)

@lildude
Copy link

lildude commented Nov 6, 2020

Regarding Github, we might be lucky: github/linguist#5084 :)

You definitely will be. 😁

This is the change from the grammar that will be pulled in in this next Linguist release which looks to include the changes in textmate/d.tmbundle#20

@Geod24
Copy link
Member Author

Geod24 commented Nov 11, 2020

Oops, we broke something 💥

/++
 Someone's having a bad time
+/
void myFunction () {}

@Geod24
Copy link
Member Author

Geod24 commented Nov 11, 2020

@jacob-carlborg
Copy link

Oops, we broke something 💥

My bad, should be fixed in: textmate/d.tmbundle@e031d03.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants