-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send a notification to the author if a PR has CI failures #123
Comments
Do we really want to spam people without explicit permission? It also has the risk to ruin notifications as one of the few communication mediums. |
- use - instead of spaces to avoid command line quoting - use -dlang#123 suffix to ref issues
- use - instead of spaces to avoid command line quoting - use -dlang#123 suffix to ref issues
We currently label PRs with have two or more build failures as "needs work" as I wasn't so sure about spamming people either. Maybe we could do it once a month or when a rebase is needed? |
I've been in the following situation:
Meanwhile, the CI fails because I forgot some silly thing. The situation:
Maybe in addition to the immediate welcome comment that dlang-bot posts, we can aggregate more useful information that is collected after a CI runs, which would include
? |
Personally, I routinely go to https://github.com/pulls to get a list of things I have "on hold". It shows the CI status so if it's red, I know I have to take action. I'd rather leave it at that than spam people, as Martin mentioned. |
Yes, I guess that would work for people who do all their work on GitHub, but I think that's not everyone. |
CircleCi already does this and it's very handy as one doesn't need to observe the CI status.
Of course we would need to exclude CodeCov and make sure that we only send the notification if its a real failure (i.e. fix our transient CI problem).
The text was updated successfully, but these errors were encountered: