Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a notification to the author if a PR has CI failures #123

Open
wilzbach opened this issue Jul 2, 2017 · 5 comments
Open

Send a notification to the author if a PR has CI failures #123

wilzbach opened this issue Jul 2, 2017 · 5 comments

Comments

@wilzbach
Copy link
Member

wilzbach commented Jul 2, 2017

CircleCi already does this and it's very handy as one doesn't need to observe the CI status.
Of course we would need to exclude CodeCov and make sure that we only send the notification if its a real failure (i.e. fix our transient CI problem).

@MartinNowak
Copy link
Member

Do we really want to spam people without explicit permission? It also has the risk to ruin notifications as one of the few communication mediums.

MartinNowak added a commit to MartinNowak/dlang-bot that referenced this issue Jan 15, 2018
- use - instead of spaces to avoid command line quoting
- use -dlang#123 suffix to ref issues
MartinNowak added a commit to MartinNowak/dlang-bot that referenced this issue Jan 15, 2018
- use - instead of spaces to avoid command line quoting
- use -dlang#123 suffix to ref issues
@wilzbach
Copy link
Member Author

We currently label PRs with have two or more build failures as "needs work" as I wasn't so sure about spamming people either. Maybe we could do it once a month or when a rebase is needed?

@CyberShadow
Copy link
Member

I've been in the following situation:

  • Run into a problem that's solvable by a patch in a D component
  • Write a patch against the D component and submit it as a PR
  • Go on with whatever I was doing

Meanwhile, the CI fails because I forgot some silly thing.

The situation:

  • D maintainers are waiting for me to notice that the CI is failing and fix the PR.
  • I am waiting for a ping or some kind of comment from a D maintainer that I need to do something with the PR (or that it has been approved/merged).

Maybe in addition to the immediate welcome comment that dlang-bot posts, we can aggregate more useful information that is collected after a CI runs, which would include

  • CI status (and maybe some analysis of CI failures)
  • Aggregated coverage (if CI succeeds)
  • Pinging reviewers (if we decide we want some system on top of CODEOWNERS)

?

@Geod24
Copy link
Member

Geod24 commented May 27, 2021

Personally, I routinely go to https://github.com/pulls to get a list of things I have "on hold". It shows the CI status so if it's red, I know I have to take action. I'd rather leave it at that than spam people, as Martin mentioned.

@CyberShadow
Copy link
Member

Yes, I guess that would work for people who do all their work on GitHub, but I think that's not everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants