Warn when fixing enhancements without changelog #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary in order to allow us to mock diffs.
Diffs are served via github.com, not api.github.com.
|
Thanks for your pull request, @CyberShadow! |
Geod24
reviewed
May 28, 2021
| @@ -14,6 +14,27 @@ struct UserMessage | |||
| } | |||
|
|
|||
|
|
|||
| void checkEnhancementChangelog(in ref PullRequest pr, ref UserMessage[] msgs, | |||
There was a problem hiding this comment.
I'm using the same signature as the method below.
source/dlangbot/warnings.d
Outdated
| if (!diff.canFind("\n+++ b/changelog/")) | ||
| { | ||
| msgs ~= UserMessage(UserMessage.Type.Warning, | ||
| "Pull requests implementing enhancements should include a [full changelog entry](https://github.com/dlang/dmd/tree/master/changelog)." |
There was a problem hiding this comment.
Wait, won't this trigger for other repos too ?
There was a problem hiding this comment.
As of #273 the list of refs for non-Bugzilla-using projects should be empty, which should match projects which use the changelog directory.
There was a problem hiding this comment.
Oh I see what you mean, well spotted. Fix pushed.
RazvanN7
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178.