Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-merge-squash drops all commit messages #66

Open
MartinNowak opened this issue Mar 24, 2017 · 3 comments
Open

auto-merge-squash drops all commit messages #66

MartinNowak opened this issue Mar 24, 2017 · 3 comments

Comments

@MartinNowak
Copy link
Member

Github's squash and merge button suggests all of the commit titles, but strips merge requests. Not sure about [squash] and !fixup commit messages, but would be sensible to strip those as well.

@MartinNowak
Copy link
Member Author

Has been disabled for now by removing the auto-merge-squash labels. Should stay removed until dlang-bot learns to synthesized the correct commit message or can do rebase --autosquash itself.

@MartinNowak MartinNowak added 2-re and removed 4-fa labels Jan 15, 2018
@CyberShadow
Copy link
Member

Should we just include a list of commits and their commit messages in the merge commit message, then?

@Geod24
Copy link
Member

Geod24 commented May 27, 2021

Usually we use squash when a contributor doesn't have a proper commit separation - e.g. create 30 commits as the result of review. So IMO we should pick the PR title / body instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants