docs: update readme to indicate the port binding #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super useful information. |
whalelines
reviewed
Aug 29, 2024
sonarqube/README.md
Outdated
| @@ -102,6 +102,14 @@ To run a cluster with the Data Center Edition, please refer to Installing SonarQ | |||
|
|
|||
| ## Configuration | |||
|
|
|||
| ### Port binding | |||
|
|
|||
| By default, the image will use port 9000 | |||
There was a problem hiding this comment.
Perhaps something like "By default, the server running within the container will listen on port 9000. You can expose the container port 9000 to the host port 9000 with the -p 9000:9000 argument to docker run:" would be more clear?
There was a problem hiding this comment.
I will update the text, like your suggestion.
I also will ajust the pull request like @tianon indicated.
|
A few notes:
|
This reverts commit cd21ac9.
…onment, using a web browser
|
@tianon, @whalelines and @alvdavi |
|
all good on our side; thanks a lot for taking the time to improve our documentation. |
tianon
reviewed
Aug 30, 2024
Co-authored-by: Tianon Gravi <[email protected]>
Co-authored-by: Tianon Gravi <[email protected]>
Co-authored-by: Tianon Gravi <[email protected]>
Co-authored-by: Tianon Gravi <[email protected]>
Co-authored-by: Tianon Gravi <[email protected]>
tianon
approved these changes
Aug 30, 2024
|
thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make it easier for developers who want to run SonarQube in a container, I think it is worth indicating the port binding when running the docker run command.
Our exemple are using the tag 10.6.0-community