Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify function signature and return type #30

Closed
jenniferjiangkells opened this issue Jun 6, 2024 · 0 comments · Fixed by #38
Closed

Clarify function signature and return type #30

jenniferjiangkells opened this issue Jun 6, 2024 · 0 comments · Fixed by #38
Labels
Issue: Feature Request ✨ New feature or improvement to existing feature

Comments

@jenniferjiangkells
Copy link
Member

jenniferjiangkells commented Jun 6, 2024

Currently the function signature for client and service functions is fixed:

  • Service functions must take str as input and return Dict.
  • Client functions must return an object of data generator type.

For service functions we can use the signature module and type check dynamically.
For client functions we're a bit more constrained atm - might have to make this more clear in the documentation.

Alternatively we may follow the principle that explicit = better and just have the users explicitly import the Pydantic models -> actually I think we should do this

@jenniferjiangkells jenniferjiangkells added the Issue: Feature Request ✨ New feature or improvement to existing feature label Jun 6, 2024
@github-project-automation github-project-automation bot moved this to Backlog in HealthChain Jun 6, 2024
@jenniferjiangkells jenniferjiangkells changed the title Dynamically determine function signature and return types Improve function signature and return type checking Jun 6, 2024
@jenniferjiangkells jenniferjiangkells changed the title Improve function signature and return type checking Clarify function signature and return type Jun 10, 2024
@jenniferjiangkells jenniferjiangkells linked a pull request Jun 11, 2024 that will close this issue
4 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Done in HealthChain Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request ✨ New feature or improvement to existing feature
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant