Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Test coverage in PR builds is complete #7439

Open
joperezr opened this issue Feb 6, 2025 · 3 comments
Open

Ensure Test coverage in PR builds is complete #7439

joperezr opened this issue Feb 6, 2025 · 3 comments
Assignees
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Milestone

Comments

@joperezr
Copy link
Member

joperezr commented Feb 6, 2025

For the past couple of weeks we've been moving some of our test execution from Helix to also run on GitHub Actions to help running them more efficiently, but at the time, we had not disabled them from also running in Helix as we were mostly doing it as a proof of concept. Today, an intermittent outage with one of our container registries pushed us to need to fully disable tests running in Helix in order to be able to unblock progress and being able to merge changes in.

This issue is meant to track the investigation of all of the tests that still need to be moved into GHA and were only running in Helix, which after the change above we are no longer covering in PRs. Once we have the list of missing things, we should then use this issue to also track the progress of moving all of those to github actions.

This should be done for 9.1.

cc: @davidfowl @radical @eerhardt @DamianEdwards @ReubenBond

@joperezr joperezr added this to the 9.1 milestone Feb 6, 2025
@danmoseley danmoseley added the area-engineering-systems infrastructure helix infra engineering repo stuff label Feb 7, 2025
@radical
Copy link
Member

radical commented Feb 12, 2025

Is anyone working on this, or parts of it?

@eerhardt
Copy link
Member

Is anyone working on this, or parts of it?

There are 3 sub-tasks. Dashboard one is already resolved. The ElasticSearch has a PR out (#7547). And @captainsafia was looking at the AzureFunctions one, I believe.

@radical
Copy link
Member

radical commented Feb 13, 2025

Is anyone working on this, or parts of it?

There are 3 sub-tasks. Dashboard one is already resolved. The ElasticSearch has a PR out (#7547). And @captainsafia was looking at the AzureFunctions one, I believe.

Thanks!

IIUC, the workload tests, and playground tests are also disabled. I'm working on those in #7568 .

@danmoseley danmoseley modified the milestones: 9.1, 9.2 Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Projects
None yet
Development

No branches or pull requests

4 participants