Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullness issue - constructor and properties of the DU root, when consumed in C#, do not show nullability of fields #18078

Open
1 of 7 tasks
T-Gro opened this issue Nov 27, 2024 · 0 comments · May be fixed by #18079
Open
1 of 7 tasks
Assignees
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug Needs-Triage
Milestone

Comments

@T-Gro
Copy link
Member

T-Gro commented Nov 27, 2024

Issue description

Reference type DU can be optimized into a single root class with fields.
Either when it is a single-case DU.
Or when it uses null as true value for the nullary cases.

In both scenarios, C# consumers do not see field nullability in the generated constructor.

Choose one or more from the following categories of impact

  • Unexpected nullness warning (false positive in nullness checking, code uses --checknulls and langversion:preview).
  • Missing nullness warning in a case which can produce nulls (false negative, code uses --checknulls and langversion:preview).
  • Breaking change related to older null constructs in code not using the checknulls switch.
  • Breaking change related to generic code and explicit type constraints (null, not null).
  • Type inference issue (i.e. code worked without type annotations before, and applying the --checknulls enforces type annotations).
  • C#/F# interop issue related to nullness metadata.
  • Other (none of the categories above apply).

Operating System

Windows (Default)

What .NET runtime/SDK kind are you seeing the issue on

.NET SDK (.NET Core, .NET 5+)

.NET Runtime/SDK version

No response

Reproducible code snippet and actual behavior

[<NoComparison;NoEquality>]
type SingleCaseDu = SingleCaseItIs of nullableString:(string|null)

[<CompilationRepresentation(CompilationRepresentationFlags.UseNullAsTrueValue)>]
[<NoEquality; NoComparison>]
type NonGenericNullAsTrueValue = 
    | MyNone
    | MySome of nullableString:(string|null)

Possible workarounds

No response

@T-Gro T-Gro added Area-Nullness Issues related to handling of Nullable Reference Types Bug Needs-Triage labels Nov 27, 2024
@T-Gro T-Gro self-assigned this Nov 27, 2024
@github-actions github-actions bot added this to the Backlog milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug Needs-Triage
Projects
Status: New
1 participant