Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Investigate if MauiCALayer needs to use a weakreference for the IShape #26169

Open
PureWeen opened this issue Nov 27, 2024 · 0 comments
Open
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing memory-leak 💦 Memory usage grows / objects live forever (sub: perf) p/2 Work that is important, but is currently not scheduled for release

Comments

@PureWeen
Copy link
Member

PureWeen commented Nov 27, 2024

Description

We should confirm this a bit more

		[UnconditionalSuppressMessage("Memory", "MEM0002", Justification = "IShape is a non-NSObject in MAUI.")]
		IShape? _shape;

You might get some shapes that inherit from View and those will have Handlers and NSObjects associated with them

public sealed partial class RoundRectangle : Shape, IShape, IRoundRectangle

Reproduction

Haven't been ablet to reproduce as of yet.
From what I can tell everything is collecting without any issues.

I've just seen some signs of lingering in larger apps but still need to narrow down if this is a culprit

@PureWeen PureWeen added this to the .NET 9 SR2 milestone Nov 27, 2024
@dotnet-policy-service dotnet-policy-service bot added the s/triaged Issue has been reviewed label Nov 27, 2024
@PureWeen PureWeen added p/0 Work that we can't release without p/2 Work that is important, but is currently not scheduled for release and removed s/triaged Issue has been reviewed labels Nov 27, 2024
@PureWeen PureWeen modified the milestones: .NET 9 SR2, .NET 9 Servicing Nov 27, 2024
@PureWeen PureWeen added area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing memory-leak 💦 Memory usage grows / objects live forever (sub: perf) and removed p/0 Work that we can't release without labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing memory-leak 💦 Memory usage grows / objects live forever (sub: perf) p/2 Work that is important, but is currently not scheduled for release
Projects
Status: Todo
Development

No branches or pull requests

1 participant