-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Fixed the text and icon color issues in the DatePicker when hovering over it. #27147
base: main
Are you sure you want to change the base?
Conversation
Hey there @Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you include an UITest? I can include something like a MovePointer
and MovePointerToCoordinate
methods.
I have included the test sample and test case. Could you please review them and let me know if you have any concerns? @jsuarezruiz |
{ | ||
App.WaitForElement("Label"); | ||
|
||
//need to include something like a MovePointer and MovePointerToCoordinate methods for hovering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have done tests with different approaches:
Using the Hover command https://github.com/appium/appium-windows-driver?tab=readme-ov-file#windows-hover is not available in the used version:
An exception of type 'System.NotImplementedException' occurred in WebDriver.dll but was not handled in user code
Unknown windows command 'hover'. Only startRecordingScreen,stopRecordingScreen,deleteFile,deleteFolder commands are supported.
Trying to move the cursor fails because using PointerKind.Mouse:
OpenQA.Selenium.WebDriverException: 'Currently only pen and touch pointer input source types are supported'
Can give a way to move the cursor using Win32, but want to test more options.
So, for now, can avoid the test, or use a Device Test to verify the color in the added resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your response. I have looked into the device test for the DatePicker hovering test case but couldn't find any relevant references for it. Could you please share any related references for hovering testcase if available, or can we avoid this test for now? @jsuarezruiz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @mattleibow has a PR here that provides this behavior
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Looks like a legit test fail |
/rebase |
1d51732
to
b0a6504
Compare
Issue
Root Cause of the issue
Description of Change
Issues Fixed
Fixes #22987
Test Case
Tested the behaviour in the following platforms
Screenshot
HoveringIssue.mp4
HoveringFixed.mp4