Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ngen Priorities for VS #77748

Conversation

AlexDelepine
Copy link

Adjusting the ngen priorities of a few VS assemblies.

The following assemblies are going from priority 3 to priority 1:
Microsoft.CodeAnalysis.CSharp.Features.dll
Microsoft.CodeAnalysis.CSharp.Workspaces.dll
Microsoft.CodeAnalysis.EditorFeatures.dll
Microsoft.CodeAnalysis.LanguageServer.Protocol.dll

This one from priority 3 to priority 2:
Microsoft.CodeAnalysis.Remote.Workspaces.dll

And this one from priority 1 to 3:
Microsoft.CodeAnalysis.Remote.ServiceHub.dll

We are experimenting with a mechanism to asynchronously generate important NGEN images immediately after VS setup in 17.14, and to do this are adjusting NGEN priorities of assemblies, so that the most important ones, based on JIT time, usage and user observable scenarios, are generated first. These changes are as a result of that analysis. If you have any questions on this, feel free to reach out to me or the VS Perf and Rel team.

@AlexDelepine AlexDelepine requested a review from a team as a code owner March 21, 2025 22:00
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 21, 2025
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Mar 21, 2025
@jasonmalinowski
Copy link
Member

This one from priority 3 to priority 2:
Microsoft.CodeAnalysis.Remote.Workspaces.dll

And this one from priority 1 to 3:
Microsoft.CodeAnalysis.Remote.ServiceHub.dll

I'd imagine those would both load about the same time so I'm surprised we'd have different priorities for them.

@AlexDelepine
Copy link
Author

@jasonmalinowski the new priorities were assigned based on JIT time of a few different scenarios that we tested, so even if some assemblies may load at the same time, the amount of time that is spent jitting is different so the priorities differ based on that.

@RikkiGibson
Copy link
Contributor

RikkiGibson commented Mar 27, 2025

Kicking off a validation insertion. We should have results by EOD or tomorrow AM. https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=11294552&view=results

edit: the first attempt seems to have failed in some unrecoverable way. replaced with a link to second attempt.

@RikkiGibson RikkiGibson removed the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Mar 27, 2025
@AlexDelepine AlexDelepine changed the base branch from main to release/dev17.14 April 2, 2025 00:29
@JoeRobich
Copy link
Member

@RikkiGibson RikkiGibson merged commit f76d6ab into dotnet:release/dev17.14 Apr 2, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants