Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ProjectDiagnosticAnalyzer type #77899

Merged
merged 11 commits into from
Apr 2, 2025
Merged

Remove the ProjectDiagnosticAnalyzer type #77899

merged 11 commits into from
Apr 2, 2025

Conversation

CyrusNajmabadi
Copy link
Member

Currently 'draft' as this depends on TypeScript having moved entirely to LSP pull diagnostics.

TS pr to move them off of us is here: https://devdiv.visualstudio.com/DevDiv/_git/TypeScript-VS/pullrequest/623063

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 28, 2025
@CyrusNajmabadi CyrusNajmabadi changed the base branch from release/dev17.15 to main April 1, 2025 17:42
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review April 2, 2025 02:00
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 2, 2025 02:00
@CyrusNajmabadi CyrusNajmabadi requested a review from dibarbet April 2, 2025 02:00
@CyrusNajmabadi
Copy link
Member Author

TS PR has gone in. So we can remove this now.

CyrusNajmabadi
CyrusNajmabadi commented Apr 2, 2025
View reviewed changes
src/EditorFeatures/Test/Diagnostics/DiagnosticAnalyzerServiceTests.cs
@@ -239,7 +239,7 @@ public async Task TestHostAnalyzerErrorNotLeaking()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

view with whitespace off.

@tmat
Copy link
Member

tmat commented Apr 2, 2025

Are we going to be able to remove DocumentDiagnosticAnalyzer as well?

@CyrusNajmabadi
Copy link
Member Author

Not yet. We use it for file-content-load and sg-error diagnostic reporting.

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge April 2, 2025 02:18
@CyrusNajmabadi CyrusNajmabadi merged commit ffd763a into dotnet:main Apr 2, 2025
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the removeProjectAnalyzer2 branch April 2, 2025 03:27
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 2, 2025
CyrusNajmabadi added a commit to CyrusNajmabadi/roslyn that referenced this pull request Apr 2, 2025
@CyrusNajmabadi
Revert "Remove the ProjectDiagnosticAnalyzer type (dotnet#77899)"
33653ff 
This reverts commit ffd763a, reversing
changes made to ff34293.
arunchndr added a commit that referenced this pull request Apr 2, 2025
@arunchndr
Revert "Remove the ProjectDiagnosticAnalyzer type (#77899)" (#77969)
b5d7ffb 
This reverts commit ffd763a, reversing
changes made to ff34293.

We need TypeScript to flow into the d18initial branch first.
CyrusNajmabadi added a commit to CyrusNajmabadi/roslyn that referenced this pull request Apr 2, 2025
@CyrusNajmabadi
Reapply "Remove the ProjectDiagnosticAnalyzer type (dotnet#77899)" (d…
d415885 
…otnet#77969)

This reverts commit b5d7ffb, reversing
changes made to 4ff7d42.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmat tmat tmat approved these changes

@dibarbet dibarbet Awaiting requested review from dibarbet

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
2 participants
@CyrusNajmabadi @tmat