Erroneous IDE0028 warning

[SoftCircuits]

I'm having the following issue with Visual Studio 17.13.5 and .NET 9.

List<Transaction> Transactions;
BindingList<Transaction> TransactionList;

// Initialize Transactions here

TransactionList = new(Account.Imports);

The last line gives me warning IDE0028 Collection initialization can be simplified. If I choose the option to fix the code, it is changed to the following.

TransactionList = [.. Account.Imports];

I'm not sure I understand all the ramifications of this change. But after making it, the code no longer works.

Now, when I assign TransactionsList to the DataSource property of a ListBox or DataGridView, changes to the list are no longer reflected in the underlying list (Transactions).

As a side note, I personally find [.. Account.Imports] quite ugly. In particular, I really like ToList() at the end of a complex LINQ expression. It looks very clean to me, and I can put it on its own line. It's very easy to read. But now that gives a similar warning as well. And the [.. collection] is particularly ugly when it spans multiple lines. I don't understand how this recommendation came to be, but I wish this decision was not made.

[CyrusNajmabadi]

As a side note, I personally find [.. Account.Imports] quite ugly.

You should disable the analyzer rule IDE then that suggested this. IDEXXXX rules are not mandatory. They're suggestions that you can apply if you prefer teh result over the way you wrote it before. If you do not, you don't have to use it, or apply any particular suggestion.

I don't understand how this recommendation came to be

The same way as all suggestions that offer a language feature that does the same thing as explicitly writing out the code in full. When we add new language features, we offer suggestions to use it over the full/explicit form. Whether you want that or not is up to you, which is why it's always just a suggestion, and not any sort of warning/error to not use the form you originally had.

[SoftCircuits]

@CyrusNajmabadi Yes, I'm aware you can disable these warnings. But that doesn't make all of them are a good idea. I'm just expressing my opinion, which, if followed, would have prevented the bug I described.

[CyrusNajmabadi]

which, if followed, would have prevented the bug I described.

not applying any analyzer suggestion will help avoid all bugs in analyzers :)