Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/msbuild #44977

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[main] Update dependencies from dotnet/msbuild #44977

wants to merge 7 commits into from
+11 −11

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 20, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

  • Subscription: 51256791-e30b-4b96-f2b9-08daf1d75f3f
  • Build: 20241127.2
  • Date Produced: November 27, 2024 9:21:10 AM UTC
  • Commit: bc2ad7fdf30ec404c4bc11cdc6d1002d988ee4a1
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
5b56997 
…1120.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.13.0-preview-24568-05 -> To Version 17.13.0-preview-24570-02
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Nov 20, 2024
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
20cdb41 
…1120.3

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.13.0-preview-24568-05 -> To Version 17.13.0-preview-24570-03
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
656e3cd 
…1121.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.13.0-preview-24568-05 -> To Version 17.13.0-preview-24571-02
@nagilson
Copy link
Member

@dotnet/msbuild-admins ILLink_can_treat_warnings_not_as_errors is failing and some other warning/error related tests, and it looks like you may have changed some warning code dotnet/msbuild@37fc828...e73ffcb. May you PTAL? @surayya-MS @JanKrivanek @JanProvaznik

@JanKrivanek
Copy link
Member

FYI @SimaTian - possible warnaserror impact?

@SimaTian
Copy link

Hello, the ILLink is using the WarningAsErrors property for their own purposes.
#12601 (comment)
Until this point this caused no issues due to the way MSBuild handled these, but now that we moved the parsing to the engine level, it clashed with their "overload".
I will revert the change in Main for now, so that we're not blocking msbuild->sdk merges and we'll take it from there.

This was referenced Nov 26, 2024
Merged
Closed
@SimaTian
Copy link

After some further discussion we've decided against reverting. I will disable the tests for now and create a follow up issue to handle them.

@SimaTian SimaTian requested a review from a team as a code owner November 26, 2024 10:57
@SimaTian SimaTian mentioned this pull request Nov 26, 2024
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
67fba37 
…1126.1

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.13.0-preview-24568-05 -> To Version 17.13.0-preview-24576-01
@nagilson nagilson mentioned this pull request Nov 26, 2024
Open
@nagilson
Copy link
Member

@dotnet/msbuild-admins Thank you and @SimaTian for following up.

There is a new problem with analyzers. I think this might be on msbuild to look into.

error : The .NET SDK has newer analyzers with version '10.0.0' than what version '5.0.3' of 'Microsoft.CodeAnalysis.NetAnalyzers' package provides. Update or remove this package reference. [/datadisks/disk1/work/AB970987/w/AFD10983/e/testExecutionDirectory/AnalyzersAreC---4DE360D4/AnalyzersAreConflictResolved/AnalyzersAreConflictResolved.csproj]
AnalyzersAreConflictResolved -> /datadisks/disk1/work/AB970987/w/AFD10983/e/testExecutionDirectory/AnalyzersAreC---4DE360D4/AnalyzersAreConflictResolved/bin/Debug/net10.0/AnalyzersAreConflictResolved.dll

@nagilson nagilson added msbuild-analyzer-candidate Items that would be a good MSBuild Analyzer Area-ILLink labels Nov 26, 2024
@nagilson nagilson mentioned this pull request Nov 26, 2024
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2024…
6710f8d 
…1127.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.13.0-preview-24568-05 -> To Version 17.13.0-preview-24577-02
@surayya-MS
Copy link
Member

looking into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagilson nagilson nagilson approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow Area-ILLink msbuild-analyzer-candidate Items that would be a good MSBuild Analyzer untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nagilson @JanKrivanek @SimaTian @surayya-MS