Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable scenario-tests execution in VMR #45109

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Conversation

ViktorHofer
Copy link
Member

No description provided.

@ViktorHofer ViktorHofer requested review from a team as code owners November 25, 2024 13:37
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Nov 25, 2024
@ViktorHofer
Copy link
Member Author

Apparently, dotnet/scenario-tests@5f25b3a doesn't work.

@ViktorHofer ViktorHofer enabled auto-merge (squash) November 25, 2024 21:49
@ViktorHofer ViktorHofer disabled auto-merge November 26, 2024 10:17
@ViktorHofer
Copy link
Member Author

I'm not sure how I should diagnose this when no pipeline artifacts are getting uploaded on failed builds...

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Nov 26, 2024

Oh I know what's going on. We don't have a dotnet in the SDK layout anymore (omg). Probably related to the join point work.

@mthalman
Copy link
Member

We don't have a dotnet in the SDK layout anymore

Seems like an important file. 😄

@ViktorHofer
Copy link
Member Author

OK, I believe this has to do with SignTool dropping files when repacking the .tar.gz container: dotnet/arcade#15232

@ViktorHofer ViktorHofer enabled auto-merge (squash) November 28, 2024 17:56
@ViktorHofer ViktorHofer merged commit 0a2413f into main Nov 28, 2024
38 checks passed
@ViktorHofer ViktorHofer deleted the ScenarioTEstsReEnable branch November 28, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants