VMR: Don't set TargetRid for portable linux-musl builds

[akoeplinger]

It is already the default and is easy to accidentally not keep in sync when copy/pasting.

[akoeplinger]

/azp run sdk-unified-build-full

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ViktorHofer]

For my education, where is the default set?

[akoeplinger]

hmm you're right, I got confused by the arcade docs but we're actually defaulting this here:

sdk/src/SourceBuild/content/Directory.Build.props

Lines 56 to 80 in 959a745

	<PropertyGroup Label="CalculateRID">
	<!-- Use current machine distro RID if set. Otherwise, fall back to RuntimeInformation.RuntimeIdentifier -->
	<BuildRid>$(__DistroRid)</BuildRid>
	<BuildRid Condition="'$(BuildRid)' == '' and '$(MSBuildRuntimeType)' == 'core'">$([System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier)</BuildRid>
	<BuildRid Condition="'$(BuildRid)' == '' and '$(MSBuildRuntimeType)' != 'core'">win-$([System.Runtime.InteropServices.RuntimeInformation]::OSArchitecture.ToString().ToLowerInvariant)</BuildRid>
	<TargetRid Condition="'$(TargetRid)' == ''">$(BuildRid.Substring(0, $(BuildRid.LastIndexOf('-'))))-$(TargetArchitecture)</TargetRid>
	<HostRid Condition="'$(HostRid)' == ''">$(TargetRid)</HostRid>
	<!-- Source-only builds are non portable, except for cross-builds.
	Source-only cross-builds default to the portable configuration so the resulting SDK works on a wider range of distros. -->
	<PortableBuild Condition="'$(PortableBuild)' == '' and '$(DotNetBuildSourceOnly)' == 'true' and '$(BuildArchitecture)' == '$(TargetArchitecture)'">false</PortableBuild>
	<PortableBuild Condition="'$(PortableBuild)' == ''">true</PortableBuild>
	<PortableRid Condition="'$(__PortableTargetOS)' != ''">$(__PortableTargetOS)-$(TargetArchitecture)</PortableRid>
	<PortableRid Condition="'$(PortableRid)' == '' and '$(TargetOS)' == 'freebsd'">freebsd-$(TargetArchitecture)</PortableRid>
	<PortableRid Condition="'$(PortableRid)' == '' and '$(TargetOS)' == 'osx'">osx-$(TargetArchitecture)</PortableRid>
	<PortableRid Condition="'$(PortableRid)' == '' and '$(TargetOS)' == 'linux'">linux-$(TargetArchitecture)</PortableRid>
	<PortableRid Condition="$(TargetRid.StartsWith('linux-musl')) or $(TargetRid.StartsWith('alpine'))">linux-musl-$(TargetArchitecture)</PortableRid>
	<PortableRid Condition="'$(PortableRid)' == '' and '$(TargetOS)' == 'windows'">win-$(TargetArchitecture)</PortableRid>
	<TargetRid Condition="'$(PortableBuild)' == 'true' and '$(PortableRid)' != ''">$(PortableRid)</TargetRid>
	<TargetRid Condition="'$(ShortStack)' == 'true' and '$(TargetOS)' != 'windows'">$(TargetOS)-$(TargetArchitecture)</TargetRid>
	<TargetRid Condition="'$(ShortStack)' == 'true' and '$(TargetOS)' == 'windows'">win-$(TargetArchitecture)</TargetRid>
	</PropertyGroup>

and that will override the RID to be linux-x64 instead of linux-musl-x64 in some cases. I'm not sure if that's expected, I'd have thought passing TargetOS/TargetArchitecture should be enough unless you want to do a non-portable build.

I'll fix the TargetRid mismatch instead.

[akoeplinger]

#45194