From a26afb27f6807a21d64cc4b2ed3cb9f236e7d67a Mon Sep 17 00:00:00 2001 From: Stephen Bonikowsky Date: Wed, 3 May 2017 10:59:27 -0700 Subject: [PATCH 1/2] Active issue test cases failing due to issue #1886 * Fix certificate installation on OSX10.12 #1886 --- .../Scenarios/Binding/Custom/CustomBindingTests.4.1.0.cs | 1 + .../ExpectedExceptions/ExpectedExceptionTests.4.1.0.cs | 2 ++ .../ExpectedExceptions/ExpectedExceptionTests.4.1.1.cs | 1 + .../Scenarios/Infrastructure/SetupValidationTests.4.1.1.cs | 2 ++ ...lientCredentialTypeCertificateCanonicalNameTests.4.1.0.cs | 3 +++ .../TransportSecurity/Tcp/ClientCredentialTypeTests.4.1.0.cs | 3 +++ .../TransportSecurity/Tcp/ClientCredentialTypeTests.4.1.1.cs | 5 +++++ .../Security/TransportSecurity/Tcp/IdentityTests.4.1.0.cs | 1 + .../Security/TransportSecurity/Tcp/IdentityTests.4.1.1.cs | 1 + 9 files changed, 19 insertions(+) diff --git a/src/System.Private.ServiceModel/tests/Scenarios/Binding/Custom/CustomBindingTests.4.1.0.cs b/src/System.Private.ServiceModel/tests/Scenarios/Binding/Custom/CustomBindingTests.4.1.0.cs index c03f82335c7..92ba851d74b 100644 --- a/src/System.Private.ServiceModel/tests/Scenarios/Binding/Custom/CustomBindingTests.4.1.0.cs +++ b/src/System.Private.ServiceModel/tests/Scenarios/Binding/Custom/CustomBindingTests.4.1.0.cs @@ -13,6 +13,7 @@ public partial class CustomBindingTests : ConditionalWcfTest { // Tcp: Client and Server bindings setup exactly the same using default settings. [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Root_Certificate_Installed), nameof(Client_Certificate_Installed))] [OuterLoop] public static void DefaultSettings_Tcp_Binary_Echo_RoundTrips_String() diff --git a/src/System.Private.ServiceModel/tests/Scenarios/Client/ExpectedExceptions/ExpectedExceptionTests.4.1.0.cs b/src/System.Private.ServiceModel/tests/Scenarios/Client/ExpectedExceptions/ExpectedExceptionTests.4.1.0.cs index 16148fe211f..b8e04052bca 100644 --- a/src/System.Private.ServiceModel/tests/Scenarios/Client/ExpectedExceptions/ExpectedExceptionTests.4.1.0.cs +++ b/src/System.Private.ServiceModel/tests/Scenarios/Client/ExpectedExceptions/ExpectedExceptionTests.4.1.0.cs @@ -329,6 +329,7 @@ public static void DuplexCallback_Throws_FaultException_ReturnsFaultedTask() } [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [OuterLoop] // Verify product throws MessageSecurityException when the Dns identity from the server does not match the expectation public static void TCP_ServiceCertExpired_Throw_MessageSecurityException() @@ -372,6 +373,7 @@ public static void TCP_ServiceCertExpired_Throw_MessageSecurityException() } [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [OuterLoop] // Verify product throws SecurityNegotiationException when the service cert is revoked public static void TCP_ServiceCertRevoked_Throw_SecurityNegotiationException() diff --git a/src/System.Private.ServiceModel/tests/Scenarios/Client/ExpectedExceptions/ExpectedExceptionTests.4.1.1.cs b/src/System.Private.ServiceModel/tests/Scenarios/Client/ExpectedExceptions/ExpectedExceptionTests.4.1.1.cs index 3e8716f262e..5987257c555 100644 --- a/src/System.Private.ServiceModel/tests/Scenarios/Client/ExpectedExceptions/ExpectedExceptionTests.4.1.1.cs +++ b/src/System.Private.ServiceModel/tests/Scenarios/Client/ExpectedExceptions/ExpectedExceptionTests.4.1.1.cs @@ -12,6 +12,7 @@ public partial class ExpectedExceptionTests : ConditionalWcfTest { [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Root_Certificate_Installed), nameof(Client_Certificate_Installed))] [OuterLoop] // Confirm that the Validate method of the custom X509CertificateValidator is called and that an exception thrown there is handled correctly. diff --git a/src/System.Private.ServiceModel/tests/Scenarios/Infrastructure/SetupValidationTests.4.1.1.cs b/src/System.Private.ServiceModel/tests/Scenarios/Infrastructure/SetupValidationTests.4.1.1.cs index 66416ad6d52..95b3a231d74 100644 --- a/src/System.Private.ServiceModel/tests/Scenarios/Infrastructure/SetupValidationTests.4.1.1.cs +++ b/src/System.Private.ServiceModel/tests/Scenarios/Infrastructure/SetupValidationTests.4.1.1.cs @@ -11,6 +11,7 @@ public class SetupValidationTests : ConditionalWcfTest { [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Root_Certificate_Installed))] [OuterLoop] public static void Root_Certificate_Correctly_Installed() @@ -59,6 +60,7 @@ public static void Client_Certificate_Correctly_Installed() } [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Peer_Certificate_Installed))] [OuterLoop] public static void Peer_Certificate_Correctly_Installed() diff --git a/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/ClientCredentialTypeCertificateCanonicalNameTests.4.1.0.cs b/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/ClientCredentialTypeCertificateCanonicalNameTests.4.1.0.cs index 14e0e4ffe2f..255d87de86b 100644 --- a/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/ClientCredentialTypeCertificateCanonicalNameTests.4.1.0.cs +++ b/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/ClientCredentialTypeCertificateCanonicalNameTests.4.1.0.cs @@ -25,6 +25,7 @@ public class Tcp_ClientCredentialTypeCertificateCanonicalNameTests : Conditional // to pass a variation or fail a variation. [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Root_Certificate_Installed))] [OuterLoop] public static void Certificate_With_CanonicalName_Localhost_Address_EchoString() @@ -96,6 +97,7 @@ public static void Certificate_With_CanonicalName_Localhost_Address_EchoString() } [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Root_Certificate_Installed))] [OuterLoop] public static void Certificate_With_CanonicalName_DomainName_Address_EchoString() @@ -172,6 +174,7 @@ public static void Certificate_With_CanonicalName_DomainName_Address_EchoString( } [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Root_Certificate_Installed))] [OuterLoop] public static void Certificate_With_CanonicalName_Fqdn_Address_EchoString() diff --git a/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/ClientCredentialTypeTests.4.1.0.cs b/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/ClientCredentialTypeTests.4.1.0.cs index e55f535d650..b1b23db3dcd 100644 --- a/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/ClientCredentialTypeTests.4.1.0.cs +++ b/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/ClientCredentialTypeTests.4.1.0.cs @@ -13,6 +13,7 @@ public partial class Tcp_ClientCredentialTypeTests : ConditionalWcfTest { [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Root_Certificate_Installed), nameof(Client_Certificate_Installed))] [OuterLoop] public static void TcpClientCredentialType_Certificate_EchoString() @@ -61,6 +62,7 @@ public static void TcpClientCredentialType_Certificate_EchoString() } [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Root_Certificate_Installed), nameof(Client_Certificate_Installed))] [OuterLoop] public static void TcpClientCredentialType_Certificate_CustomValidator_EchoString() @@ -113,6 +115,7 @@ public static void TcpClientCredentialType_Certificate_CustomValidator_EchoStrin } [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Root_Certificate_Installed), nameof(Client_Certificate_Installed))] [OuterLoop] public static void TcpClientCredentialType_Certificate_With_ServerAltName_EchoString() diff --git a/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/ClientCredentialTypeTests.4.1.1.cs b/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/ClientCredentialTypeTests.4.1.1.cs index bd87cae9bea..69a511e3b99 100644 --- a/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/ClientCredentialTypeTests.4.1.1.cs +++ b/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/ClientCredentialTypeTests.4.1.1.cs @@ -14,6 +14,7 @@ public partial class Tcp_ClientCredentialTypeTests : ConditionalWcfTest { [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Root_Certificate_Installed), nameof(Client_Certificate_Installed), nameof(Peer_Certificate_Installed), @@ -61,6 +62,7 @@ public static void NetTcp_SecModeTrans_CertValMode_PeerTrust_Succeeds_In_Trusted } [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Root_Certificate_Installed), nameof(Client_Certificate_Installed), nameof(Peer_Certificate_Installed), @@ -119,6 +121,7 @@ public static void NetTcp_SecModeTrans_CertValMode_PeerTrust_Fails_Not_In_Truste } [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Root_Certificate_Installed), nameof(Client_Certificate_Installed), nameof(SSL_Available))] @@ -166,6 +169,7 @@ public static void NetTcp_SecModeTrans_CertValMode_PeerOrChainTrust_Succeeds_Cha } [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Root_Certificate_Installed), nameof(Client_Certificate_Installed), nameof(SSL_Available))] @@ -211,6 +215,7 @@ public static void NetTcp_SecModeTrans_CertValMode_ChainTrust_Succeeds_ChainTrus } [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Root_Certificate_Installed), nameof(Client_Certificate_Installed), nameof(SSL_Available))] diff --git a/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/IdentityTests.4.1.0.cs b/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/IdentityTests.4.1.0.cs index 240f1a2fa63..5cba7f4fe89 100644 --- a/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/IdentityTests.4.1.0.cs +++ b/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/IdentityTests.4.1.0.cs @@ -13,6 +13,7 @@ public partial class IdentityTests : ConditionalWcfTest { [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Root_Certificate_Installed), nameof(Client_Certificate_Installed))] [OuterLoop] // The product code will check the Dns identity from the server and throw if it does not match what is specified in DnsEndpointIdentity diff --git a/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/IdentityTests.4.1.1.cs b/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/IdentityTests.4.1.1.cs index 81057ea6f21..ff66c90f996 100644 --- a/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/IdentityTests.4.1.1.cs +++ b/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/IdentityTests.4.1.1.cs @@ -13,6 +13,7 @@ public partial class IdentityTests : ConditionalWcfTest { [WcfFact] + [Issue(1886, OS = OSID.AnyOSX)] [Condition(nameof(Root_Certificate_Installed), nameof(Client_Certificate_Installed))] [OuterLoop] // Verify product throws MessageSecurityException when the Dns identity from the server does not match the expectation From d968df5331471cb2be7388510b74f24fc199076c Mon Sep 17 00:00:00 2001 From: Stephen Bonikowsky Date: Wed, 3 May 2017 14:56:18 -0700 Subject: [PATCH 2/2] Skipping flaky test. * StreamingTests.NetTcp_TransportSecurity_Streamed_TimeOut_Long_Running_Operation has been failing more often recently, adding Active Issue to it so CI can be clean while we investigate. --- .../Security/TransportSecurity/Tcp/StreamingTests.4.1.0.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/StreamingTests.4.1.0.cs b/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/StreamingTests.4.1.0.cs index d2a75885dd9..dd90557dd6b 100644 --- a/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/StreamingTests.4.1.0.cs +++ b/src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Tcp/StreamingTests.4.1.0.cs @@ -197,6 +197,7 @@ public static void NetTcp_TransportSecurity_Streamed_MultipleReads() nameof(Windows_Authentication_Available), nameof(Ambient_Credentials_Available))] [Issue(832, Framework = FrameworkID.NetNative)] // Windows Stream Security is not supported in NET Native + [Issue(1888)] [OuterLoop] public static void NetTcp_TransportSecurity_Streamed_TimeOut_Long_Running_Operation() {