Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using ALB and Lambda with multi value headers, regular headers are not being added to the multiValueHeaders object #269

Open
grillorafael opened this issue Feb 13, 2023 · 6 comments

Comments

@grillorafael
Copy link

grillorafael commented Feb 13, 2023

Hi,

{
  'headers': {
    'someHeader': 'someValue'
  },
  'multiValueHeaders': {
    'someOtherHeader': ['someOtherValue']
  }
}

The expected outcome is that 'multiValueHeaders' contains all headers

@grillorafael
Copy link
Author

For context: when I swap to this library it works fine but serverless-http supports basePath with ALB which is what I need right now.

https://github.com/vendia/serverless-express

@arcticShadow
Copy link
Contributor

Just hit this too. Would a PR be merged if one is provided?

@dougmoscrop
Copy link
Owner

Absolutely

@arcticShadow
Copy link
Contributor

Probably should have linked it here when i posted it :-D #272

@arcticShadow
Copy link
Contributor

FYI @grillorafael this is patched in master now.

@grillorafael
Copy link
Author

I'll wait for the release. Thank you @arcticShadow !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants