Merge pull request #16 from cpick/fix-noctty

Prevent `Pty::pts()` from attaching via `O_NOCTTY`
doy · Jan 30, 2025 · 94a3bca · 94a3bca
2 parents e863a34 + 349c9ec
commit 94a3bca
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/sys.rs b/src/sys.rs
@@ -1,6 +1,6 @@
 use std::os::{
     fd::{AsRawFd as _, FromRawFd as _},
-    unix::prelude::OsStrExt as _,
+    unix::prelude::{OpenOptionsExt as _, OsStrExt as _},
 };
 
 #[derive(Debug)]
@@ -33,6 +33,7 @@ impl Pty {
         Ok(Pts(std::fs::OpenOptions::new()
             .read(true)
             .write(true)
+            .custom_flags(libc::O_NOCTTY)
             .open(std::ffi::OsStr::from_bytes(
                 rustix::pty::ptsname(&self.0, vec![])?.as_bytes(),
             ))?