Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests fail on master branch with old Linux distribution #1300

Open
adamqqqplay opened this issue May 25, 2023 · 1 comment
Open

Unit tests fail on master branch with old Linux distribution #1300

adamqqqplay opened this issue May 25, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@adamqqqplay
Copy link
Member

Additional Information

The following information is very important in order to help us to help you. Omission of the following details may delay your support request or receive no attention at all.

Version of nydus being used (nydusd --version)

master branch@ 43e6518

Version of nydus-snapshotter being used (containerd-nydus-grpc --version)

Kernel information (uname -r)

5.4.0-148-generic

GNU/Linux Distribution, if applicable (cat /etc/os-release)

NAME="Ubuntu"
VERSION="20.04.6 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.6 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

containerd-nydus-grpc command line used, if applicable (ps aux | grep containerd-nydus-grpc)

client command line used, if applicable (such as: nerdctl, docker, kubectl, ctr)

make ut-nextest

Screenshots (if applicable)

image

image

Details about issue

Some unit test fails on Ubuntu 20 (kernel 5.4.0-148-generic), but they work fine on Ubuntu 22 (kernel 5.15.0-43-generic). Maybe these errors are expected? But for unit testing, the behavior should not change due to different kernel versions.

        FAIL [   0.068s] nydus-service blob_cache::tests::test_meta_blob
        FAIL [   0.060s] nydus-service block_device::tests::test_block_device

My opinion is that it would be best to fix these unit tests, or move them into integration tests.

@adamqqqplay adamqqqplay added the bug Something isn't working label May 25, 2023
@imeoer
Copy link
Collaborator

imeoer commented May 25, 2023

cc @jiangliu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants