-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PENTAX / RICOH Support #319
Comments
Hi, Thanks |
@skorpionet100 sure, I'll be happy to guide you. First, I assume this information is stored in a "makernote". These are areas in TIFF data where manufacturers can store data specific to their devices. Note that both Exif and raw files use TIFF encoding. Some more general information about makernotes here: https://github.com/drewnoakes/metadata-extractor/wiki/Makernotes We already have a Let me know if you have any questions. |
Also, are you able and willing to donate those sample images to this project? Are they your original images? |
Sure and are my original images. |
I took a quick look at this for you. This should help: diff --git a/MetadataExtractor/Formats/Exif/ExifTiffHandler.cs b/MetadataExtractor/Formats/Exif/ExifTiffHandler.cs
index bb52ae82..e14b368d 100644
--- a/MetadataExtractor/Formats/Exif/ExifTiffHandler.cs
+++ b/MetadataExtractor/Formats/Exif/ExifTiffHandler.cs
@@ -707,6 +707,11 @@ namespace MetadataExtractor.Formats.Exif
// Always in Motorola byte order
TiffReader.ProcessIfd(this, context.WithByteOrder(isMotorolaByteOrder: true).WithShiftedBaseOffset(makernoteOffset), 8);
}
+ else if (firstTenChars.Equals("PENTAX \0II", StringComparison.Ordinal))
+ {
+ PushDirectory(new PentaxMakernoteDirectory()); // TODO use the correct directory class here
+ TiffReader.ProcessIfd(this, context.WithByteOrder(isMotorolaByteOrder: false).WithShiftedBaseOffset(makernoteOffset), 10);
+ }
}
else if (string.Equals(firstTenChars, "Apple iOS\0", StringComparison.Ordinal))
{ The use of Good luck! |
There may also be a This might be helpful too: https://exiv2.org/tags-pentax.html |
Thanks to @skorpionet100 for donating these.
Hi, can I use VS 2022? The correct way to get the code is to clone the github repository? Thanks |
@skorpionet100 yes, sorry I missed your message. VS2022 and a git clone will get you started. Create a fork of this repo, clone that to your machine, create a new branch, commit your changes, push to your fork, create a pull request here. That's the general process. You can find nice docs online to walk you through the process if you're new to it. |
I put basic support for this in #321. What remains extending the descriptor class in order to show decoded values for many of the tags. Here's an example from
As you can see, many of the values are just displayed as numbers. We need to extend the descriptor to provide these descriptions, using the data available in https://exiftool.org/TagNames/Pentax.html For inspiration, take a look at an existing descriptor class, such as |
Hi,
is possible to add the full support to the PENTAX / RICOH tags? I can provide JPG and PEF (Pentax RAW format) samples from here: https://www.wificommanderpentax.com/temp/PENTAX_IMAGES_TAGS.zip
To have a list of the PENTAX / RICOH tags go here: https://exiftool.org/TagNames/Pentax.html
Thanks
The text was updated successfully, but these errors were encountered: