Issue #3389994 by mstrelan, quietone: [random test failure] MediaTest::testViewMode

Author: catch

modules/ckeditor5/tests/src/FunctionalJavascript/MediaTest.php

@@ -880,7 +880,7 @@ public function testViewMode(bool $with_alignment): void {
     // Test that setting the view mode back to the default removes the
     // `data-view-mode` attribute.
     $this->assertFalse($drupal_media_element->hasAttribute('data-view-mode'));
-    $assert_session->elementExists('css', 'article.media--view-mode-view-mode-1');
+    $this->assertNotEmpty($assert_session->waitForElement('css', 'article.media--view-mode-view-mode-1'));
 
     // Check that the toolbar status matches "no view mode".
     $dropdown_button = $page->find('css', 'button.ck-dropdown__button > span.ck-button__label');
@@ -913,7 +913,7 @@ public function testViewMode(bool $with_alignment): void {
     $drupal_media_element = $editor_dom->getElementsByTagName('drupal-media')
       ->item(0);
     $this->assertFalse($drupal_media_element->hasAttribute('data-view-mode'));
-    $assert_session->waitForElement('css', 'article.media--view-mode-view-mode-1');
+    $this->assertNotEmpty($assert_session->waitForElement('css', 'article.media--view-mode-view-mode-1'));
 
     // Test that setting allowed_view_modes back to two items restores the
     // field.
@@ -949,7 +949,7 @@ public function testViewMode(bool $with_alignment): void {
     $this->host->save();
     $this->getSession()->reload();
     $this->waitForEditor();
-    $assert_session->elementExists('css', 'article.media--view-mode-view-mode-1');
+    $this->assertNotEmpty($assert_session->waitForElement('css', 'article.media--view-mode-view-mode-1'));
 
     $this->assertEmpty($assert_session->waitForElementVisible('css', '.drupal-media figcaption'));
     $this->click('.ck-widget.drupal-media');
@@ -977,7 +977,7 @@ public function testViewMode(bool $with_alignment): void {
     // Reload page to get new configuration.
     $this->getSession()->reload();
     $this->waitForEditor();
-    $assert_session->waitForElementVisible('css', 'article.media--view-mode-view-mode-1');
+    $this->assertNotEmpty($assert_session->waitForElementVisible('css', 'article.media--view-mode-view-mode-1'));
 
     // Test that having a default_view_mode that is not an allowed_view_mode
     // will still be added to the editor.